You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/14 06:36:15 UTC
[GitHub] [flink] lujiefsi opened a new pull request #17468: FLINK-24540 : fix resource leak due to Files.list
lujiefsi opened a new pull request #17468:
URL: https://github.com/apache/flink/pull/17468
Files.list will open dir and we should close it
see jdk:
the
{@code try}-with-resources construct should be used to ensure that the
stream's {@link Stream#close close} method is invoked after the stream
operations are completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17468: FLINK-24540 : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943032413
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 26d053e95ef27bb61332cb5491bddf69bcda93fc (Thu Oct 14 06:39:33 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24540).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17468: FLINK-24540 : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943027293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26d053e95ef27bb61332cb5491bddf69bcda93fc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17468: [FLINK-24540] : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943027293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029",
"triggerID" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"triggerType" : "PUSH"
}, {
"hash" : "d4c05101e5a177d050b7f37e0c16d7a16804ea84",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25037",
"triggerID" : "d4c05101e5a177d050b7f37e0c16d7a16804ea84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4c05101e5a177d050b7f37e0c16d7a16804ea84 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17468: FLINK-24540 : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943027293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029",
"triggerID" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26d053e95ef27bb61332cb5491bddf69bcda93fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17468: FLINK-24540 : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943027293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029",
"triggerID" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26d053e95ef27bb61332cb5491bddf69bcda93fc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17468: [FLINK-24540] : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943027293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029",
"triggerID" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"triggerType" : "PUSH"
}, {
"hash" : "d4c05101e5a177d050b7f37e0c16d7a16804ea84",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4c05101e5a177d050b7f37e0c16d7a16804ea84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26d053e95ef27bb61332cb5491bddf69bcda93fc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029)
* d4c05101e5a177d050b7f37e0c16d7a16804ea84 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17468: [FLINK-24540] : fix resource leak due to Files.list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17468:
URL: https://github.com/apache/flink/pull/17468#issuecomment-943027293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029",
"triggerID" : "26d053e95ef27bb61332cb5491bddf69bcda93fc",
"triggerType" : "PUSH"
}, {
"hash" : "d4c05101e5a177d050b7f37e0c16d7a16804ea84",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25037",
"triggerID" : "d4c05101e5a177d050b7f37e0c16d7a16804ea84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26d053e95ef27bb61332cb5491bddf69bcda93fc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25029)
* d4c05101e5a177d050b7f37e0c16d7a16804ea84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org