You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by hongbin ma <ma...@apache.org> on 2016/01/14 03:54:00 UTC
Using apache reviewboard for reviewing patches
hi community
as kylin's reviewboard is enabled on https://reviews.apache.org, we can
start to review patch with it. It is highly suggested to follow the
tutorials and use RBTools to convenient yourself :)
https://www.reviewboard.org/docs/rbtools/dev/
https://www.reviewboard.org/docs/rbtools/dev/rbt/configuration/repositories/#rbtools-repo-config
http://blog.beanbaginc.com/2014/12/08/5-tips-for-your-rbtools-workflow/
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Using apache reviewboard for reviewing patches
Posted by Li Yang <li...@apache.org>.
I see patch files and PR basically the same thing. Personally prefer patch
file, but PR is fine too.
On Thu, Jan 14, 2016 at 4:48 PM, hongbin ma <ma...@apache.org> wrote:
> good point
>
> in this case we should think about trying out both review ways, and pick
> whichever suits us:)
>
> On Thu, Jan 14, 2016 at 4:45 PM, 250635732@qq.com <25...@qq.com>
> wrote:
>
> > No idea why hadoop and hbase community not utilize github. But spark
> > community usually use github
> > to send pr and patches. Maybe more flexible to review and merge.
> >
> >
> >
> > 250635732@qq.com
> >
> > From: hongbin ma
> > Date: 2016-01-14 16:43
> > To: dev
> > Subject: Re: Using apache reviewboard for reviewing patches
> > I had a impression that asf git is not well integrated with github, so
> for
> > a long time we tried not to use github.
> >
> > btw, why do projects like hadoop,hbase not to use github for reviewing?
> >
> >
> >
> >
> > --
> > Regards,
> >
> > *Bin Mahone | 马洪宾*
> > Apache Kylin: http://kylin.io
> > Github: https://github.com/binmahone
> >
>
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
Re: Re: Using apache reviewboard for reviewing patches
Posted by hongbin ma <ma...@apache.org>.
good point
in this case we should think about trying out both review ways, and pick
whichever suits us:)
On Thu, Jan 14, 2016 at 4:45 PM, 250635732@qq.com <25...@qq.com> wrote:
> No idea why hadoop and hbase community not utilize github. But spark
> community usually use github
> to send pr and patches. Maybe more flexible to review and merge.
>
>
>
> 250635732@qq.com
>
> From: hongbin ma
> Date: 2016-01-14 16:43
> To: dev
> Subject: Re: Using apache reviewboard for reviewing patches
> I had a impression that asf git is not well integrated with github, so for
> a long time we tried not to use github.
>
> btw, why do projects like hadoop,hbase not to use github for reviewing?
>
>
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Using apache reviewboard for reviewing patches
Posted by "250635732@qq.com" <25...@qq.com>.
No idea why hadoop and hbase community not utilize github. But spark community usually use github
to send pr and patches. Maybe more flexible to review and merge.
250635732@qq.com
From: hongbin ma
Date: 2016-01-14 16:43
To: dev
Subject: Re: Using apache reviewboard for reviewing patches
I had a impression that asf git is not well integrated with github, so for
a long time we tried not to use github.
btw, why do projects like hadoop,hbase not to use github for reviewing?
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Using apache reviewboard for reviewing patches
Posted by hongbin ma <ma...@apache.org>.
I had a impression that asf git is not well integrated with github, so for
a long time we tried not to use github.
btw, why do projects like hadoop,hbase not to use github for reviewing?
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Using apache reviewboard for reviewing patches
Posted by Henry Saputra <he...@gmail.com>.
There are already Github PRs for pacthes. I think it is more convenient for
people to submit PRs to also for reviews.
With ASF git and Github integration we could just Github PR to ask for
patches and reviews.
Thoughts?
- Henry
On Wed, Jan 13, 2016 at 6:54 PM, hongbin ma <ma...@apache.org> wrote:
> hi community
>
> as kylin's reviewboard is enabled on https://reviews.apache.org, we can
> start to review patch with it. It is highly suggested to follow the
> tutorials and use RBTools to convenient yourself :)
>
> https://www.reviewboard.org/docs/rbtools/dev/
>
> https://www.reviewboard.org/docs/rbtools/dev/rbt/configuration/repositories/#rbtools-repo-config
> http://blog.beanbaginc.com/2014/12/08/5-tips-for-your-rbtools-workflow/
>
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>