You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/01/28 04:52:32 UTC
[GitHub] [openmeetings] ali-alhaidary opened a new pull request #122: Update languages.xml
ali-alhaidary opened a new pull request #122:
URL: https://github.com/apache/openmeetings/pull/122
For Arabic users, instructions should be in Arabic, and numerals are the most common keys between different users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#discussion_r566798729
##########
File path: openmeetings-web/src/main/webapp/languages/languages.xml
##########
@@ -32,7 +32,7 @@
<lang id="11" code="zh-CN" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese simplified</lang>
<lang id="12" code="zh-TW" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese traditional</lang>
<lang id="13" code="ko" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">korean</lang>
- <lang id="14" code="ar" tip="Only capital Latin latters A-Z" rangeStart="ا" rangeEnd="غ">arabic</lang>
+ <lang id="14" code="ar" tip="ادخل الرمز هنا" rangeStart="1" rangeEnd="9">عربي</lang>
Review comment:
OK, let it be :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax merged pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
solomax merged pull request #122:
URL: https://github.com/apache/openmeetings/pull/122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#discussion_r565848283
##########
File path: openmeetings-web/src/main/webapp/languages/languages.xml
##########
@@ -32,7 +32,7 @@
<lang id="11" code="zh-CN" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese simplified</lang>
<lang id="12" code="zh-TW" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese traditional</lang>
<lang id="13" code="ko" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">korean</lang>
- <lang id="14" code="ar" tip="Only capital Latin latters A-Z" rangeStart="ا" rangeEnd="غ">arabic</lang>
+ <lang id="14" code="ar" tip="ادخل الرمز هنا" rangeStart="1" rangeEnd="9">عربي</lang>
Review comment:
@ali-alhaidary Are you sure the range is correct?
I have used your previous range: 0627-063A ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] ali-alhaidary commented on a change in pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
ali-alhaidary commented on a change in pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#discussion_r566035103
##########
File path: openmeetings-web/src/main/webapp/languages/languages.xml
##########
@@ -32,7 +32,7 @@
<lang id="11" code="zh-CN" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese simplified</lang>
<lang id="12" code="zh-TW" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese traditional</lang>
<lang id="13" code="ko" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">korean</lang>
- <lang id="14" code="ar" tip="Only capital Latin latters A-Z" rangeStart="ا" rangeEnd="غ">arabic</lang>
+ <lang id="14" code="ar" tip="ادخل الرمز هنا" rangeStart="1" rangeEnd="9">عربي</lang>
Review comment:
> @ali-alhaidary Are you sure the range is correct?
> I have used your previous range: 0627-063A ....
The range given before is correct, however, after few attempts (with
moodle new registrations as well) we found out that RTL letters become
very confusing especially many of them have dots غ ع ق ف ج ح خ ض ص that
makes even harder to see, so we agreed that numerals 1-9 (we excluded
zero as well) are our best chose for all RTL that we use (and all of our
users are RTL), but you can put the older range as standard, and we
customize it locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] ali-alhaidary commented on pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
ali-alhaidary commented on pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#issuecomment-769001024
The range given before is correct, however, after few attempts (with
moodle new registrations as well) we found out that RTL letters become
very confusing especially many of them have dots غ ع ق ف ج ح خ ض ص that
makes even harder to see, so we agreed that numerals 1-9 (we excluded
zero as well) are our best chose for all RTL that we use (and all of our
users are RTL), but you can put the older range as standard, and we
customize it locally.
On 1/28/21 9:28 AM, Maxim Solodovnik wrote:
>
> *@solomax* commented on this pull request.
>
> ------------------------------------------------------------------------
>
> In openmeetings-web/src/main/webapp/languages/languages.xml
> <https://github.com/apache/openmeetings/pull/122#discussion_r565848283>:
>
> > @@ -32,7 +32,7 @@
> <lang id="11" code="zh-CN" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese simplified</lang>
> <lang id="12" code="zh-TW" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese traditional</lang>
> <lang id="13" code="ko" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">korean</lang>
> - <lang id="14" code="ar" tip="Only capital Latin latters A-Z" rangeStart="ا" rangeEnd="غ">arabic</lang>
> + <lang id="14" code="ar" tip="ادخل الرمز هنا" rangeStart="1" rangeEnd="9">عربي</lang>
>
> @ali-alhaidary <https://github.com/ali-alhaidary> Are you sure the
> range is correct?
> I have used your previous range: 0627-063A ....
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/openmeetings/pull/122#pullrequestreview-578019416>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AR6ACJYRHUQJO4GQ2OXTUITS4D7YPANCNFSM4WWNHHZQ>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] ali-alhaidary removed a comment on pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
ali-alhaidary removed a comment on pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#issuecomment-769001024
The range given before is correct, however, after few attempts (with
moodle new registrations as well) we found out that RTL letters become
very confusing especially many of them have dots غ ع ق ف ج ح خ ض ص that
makes even harder to see, so we agreed that numerals 1-9 (we excluded
zero as well) are our best chose for all RTL that we use (and all of our
users are RTL), but you can put the older range as standard, and we
customize it locally.
On 1/28/21 9:28 AM, Maxim Solodovnik wrote:
>
> *@solomax* commented on this pull request.
>
> ------------------------------------------------------------------------
>
> In openmeetings-web/src/main/webapp/languages/languages.xml
> <https://github.com/apache/openmeetings/pull/122#discussion_r565848283>:
>
> > @@ -32,7 +32,7 @@
> <lang id="11" code="zh-CN" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese simplified</lang>
> <lang id="12" code="zh-TW" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">chinese traditional</lang>
> <lang id="13" code="ko" tip="Only capital Latin latters A-Z" rangeStart="A" rangeEnd="Z">korean</lang>
> - <lang id="14" code="ar" tip="Only capital Latin latters A-Z" rangeStart="ا" rangeEnd="غ">arabic</lang>
> + <lang id="14" code="ar" tip="ادخل الرمز هنا" rangeStart="1" rangeEnd="9">عربي</lang>
>
> @ali-alhaidary <https://github.com/ali-alhaidary> Are you sure the
> range is correct?
> I have used your previous range: 0627-063A ....
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/openmeetings/pull/122#pullrequestreview-578019416>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AR6ACJYRHUQJO4GQ2OXTUITS4D7YPANCNFSM4WWNHHZQ>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #122: Update languages.xml
Posted by GitBox <gi...@apache.org>.
solomax commented on pull request #122:
URL: https://github.com/apache/openmeetings/pull/122#issuecomment-768831264
@ali-alhaidary congrats with first PR ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org