You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jo...@apache.org on 2017/04/10 09:31:59 UTC

opennlp git commit: OPENNLP-1016: Add more tests for StringList

Repository: opennlp
Updated Branches:
  refs/heads/master 395431519 -> 704866739


OPENNLP-1016: Add more tests for StringList


Project: http://git-wip-us.apache.org/repos/asf/opennlp/repo
Commit: http://git-wip-us.apache.org/repos/asf/opennlp/commit/70486673
Tree: http://git-wip-us.apache.org/repos/asf/opennlp/tree/70486673
Diff: http://git-wip-us.apache.org/repos/asf/opennlp/diff/70486673

Branch: refs/heads/master
Commit: 7048667393bc4290f381312243d13688407b9350
Parents: 3954315
Author: koji <ko...@rondhuit.com>
Authored: Mon Apr 10 14:16:34 2017 +0900
Committer: koji <ko...@rondhuit.com>
Committed: Mon Apr 10 14:16:34 2017 +0900

----------------------------------------------------------------------
 .../test/java/opennlp/tools/util/StringListTest.java | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/opennlp/blob/70486673/opennlp-tools/src/test/java/opennlp/tools/util/StringListTest.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/test/java/opennlp/tools/util/StringListTest.java b/opennlp-tools/src/test/java/opennlp/tools/util/StringListTest.java
index a57a2ae..d8c7ca2 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/util/StringListTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/util/StringListTest.java
@@ -28,6 +28,16 @@ import org.junit.Test;
 public class StringListTest {
 
   /**
+   * Tests {@link StringList} which uses {@link String#intern}.
+   */
+  @Test
+  public void testIntern() {
+    StringList l1 = new StringList("a");
+    StringList l2 = new StringList("a", "b");
+    Assert.assertTrue(l1.getToken(0) == l2.getToken(0));
+  }
+
+  /**
    * Tests {@link StringList#getToken(int)}.
    */
   @Test
@@ -90,6 +100,8 @@ public class StringListTest {
   public void testHashCode() {
     Assert.assertEquals(new StringList("a", "b").hashCode(),
         new StringList("a", "b").hashCode());
+    Assert.assertNotEquals(new StringList("a", "b").hashCode(),
+        new StringList("a", "c").hashCode());
   }
 
   /**
@@ -97,6 +109,7 @@ public class StringListTest {
    */
   @Test
   public void testToString() {
-    new StringList("a", "b").toString();
+    Assert.assertEquals("[a]", new StringList("a").toString());
+    Assert.assertEquals("[a,b]", new StringList("a", "b").toString());
   }
 }