You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "vitvara (via GitHub)" <gi...@apache.org> on 2026/10/09 13:07:30 UTC
[PR] branch-4.1: [fix](parquet) Restore column ownership after interrupted reads #66780 [doris]
vitvara opened a new pull request, #68840:
URL: https://github.com/apache/doris/pull/68840
### What problem does this PR solve?
Issue Number: None
Related PR: #66780
Problem Summary:
Cherry-pick of #66780 to branch-4.1. When a Parquet scalar column is read directly into the destination column (`read_directly_into_dst_logical_column()`), `read_column_data` moves the caller's only `ColumnPtr` into `resolved_column`; if any read step returns before `convert()` moves it back (for example when the scan is stopped), the caller is left with a null column and the BE crashes. The fix restores ownership with a `Defer` on every early return, exactly as on master.
Conflict resolution: on branch-4.1 `read_column_data` ends with `return _converter->convert(...)` directly, so the last hunk becomes `return convert_column();` (master has `RETURN_IF_ERROR(convert_column()); … return Status::OK();`) — same behaviour.
The unit test from #66780 is carried over as a standalone file, `parquet_scalar_column_reader_test.cpp`: the file it extends on master (`parquet_column_chunk_reader_test.cpp`) and the lazy-dictionary fixtures it builds on (#66000) are not on branch-4.1, so the test brings the minimal in-memory column-chunk fixture it needs.
### Release note
Fix a BE crash when a Parquet read into a nested scalar column is interrupted before the column is converted.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test: `ParquetScalarColumnReaderTest.NestedReadRestoresColumnWhenStopped` (`be/test/format/parquet/parquet_scalar_column_reader_test.cpp`)
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](parquet) Restore column ownership after interrupted reads #66780 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68840:
URL: https://github.com/apache/doris/pull/68840#issuecomment-6081503870
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](parquet) Restore column ownership after interrupted reads #66780 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68840:
URL: https://github.com/apache/doris/pull/68840#issuecomment-6095695329
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (15/15)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68840_bdaccc8fd0f098c18124c4adba1eb7849971e7a0_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68840_bdaccc8fd0f098c18124c4adba1eb7849971e7a0_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 74.91% (31955/42660) |
| Line Coverage | 59.32% (358337/604075) |
| Region Coverage | 55.89% (298063/533301) |
| Branch Coverage | 56.83% (135346/238168) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](parquet) Restore column ownership after interrupted reads #66780 [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #68840:
URL: https://github.com/apache/doris/pull/68840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1: [fix](parquet) Restore column ownership after interrupted reads #66780 [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #68840:
URL: https://github.com/apache/doris/pull/68840#issuecomment-6092693441
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org