[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #619: feat: added e2e test for Login page

[GitBox <gi...@apache.org>]

liuxiran commented on a change in pull request #619:
URL: https://github.com/apache/apisix-dashboard/pull/619#discussion_r514410688



##########
File path: src/e2e/Login.e2e.js
##########
@@ -0,0 +1,39 @@
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+let browser;
+beforeAll(async () => {
+  browser = await puppeteer.launch({ headless: true });
+});
+
+describe('Login', () => {
+  test('Login fail', async () => {

Review comment:
       it would be better to add  a failed test case: login with empty username and password, because it has different error message and page presentation :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org