You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/02 08:55:01 UTC
Review Request 13224: Fixed cgroups isolator to not try to destroy already
destroyed cgroup during recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
Summary (updated)
-----------------
Fixed cgroups isolator to not try to destroy already destroyed cgroup during recovery.
Bugs: MESOS-607
https://issues.apache.org/jira/browse/MESOS-607
Repository: mesos-git
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
Diff: https://reviews.apache.org/r/13224/diff/
Testing (updated)
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13224: Fixed cgroups isolator to not try to destroy
already destroyed cgroup during recovery.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/#review24560
-----------------------------------------------------------
Ship it!
Ship It!
- Brenden Matthews
On Aug. 2, 2013, 6:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13224/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
>
>
> Bugs: MESOS-607
> https://issues.apache.org/jira/browse/MESOS-607
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
> src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
>
> Diff: https://reviews.apache.org/r/13224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13224: Fixed cgroups isolator to not try to destroy
already destroyed cgroup during recovery.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/
-----------------------------------------------------------
(Updated Aug. 3, 2013, 8:33 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased. nnfr.
Bugs: MESOS-607
https://issues.apache.org/jira/browse/MESOS-607
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
Diff: https://reviews.apache.org/r/13224/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13224: Fixed cgroups isolator to not try to destroy
already destroyed cgroup during recovery.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/#review24555
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 2, 2013, 6:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13224/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
>
>
> Bugs: MESOS-607
> https://issues.apache.org/jira/browse/MESOS-607
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
> src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
>
> Diff: https://reviews.apache.org/r/13224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13224: Fixed cgroups isolator to not try to destroy
already destroyed cgroup during recovery.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 2, 2013, 8:05 p.m., Ben Mahler wrote:
> > src/slave/cgroups_isolator.cpp, lines 784-790
> > <https://reviews.apache.org/r/13224/diff/1/?file=334350#file334350line784>
> >
> > Is it possible for the slave to receive duplicate executorTerminated calls now?
the same slave would not get duplicate executorTerminated messages. a restarted slave might get a executorTerminated message even though the previous slave received it. we err on the side of caution here. that said, the next review ("don't recover completed executors") avoids even this as much as possible.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/#review24557
-----------------------------------------------------------
On Aug. 2, 2013, 6:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13224/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
>
>
> Bugs: MESOS-607
> https://issues.apache.org/jira/browse/MESOS-607
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
> src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
>
> Diff: https://reviews.apache.org/r/13224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13224: Fixed cgroups isolator to not try to destroy
already destroyed cgroup during recovery.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/#review24557
-----------------------------------------------------------
Ship it!
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/13224/#comment48577>
Is it possible for the slave to receive duplicate executorTerminated calls now?
- Ben Mahler
On Aug. 2, 2013, 6:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13224/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
>
>
> Bugs: MESOS-607
> https://issues.apache.org/jira/browse/MESOS-607
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
> src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
>
> Diff: https://reviews.apache.org/r/13224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>