[GitHub] [superset] nikolagigic commented on a change in pull request #12352: Add ErrorBoudary for AdhocFilter components

[GitBox <gi...@apache.org>]

nikolagigic commented on a change in pull request #12352:
URL: https://github.com/apache/superset/pull/12352#discussion_r553970754



##########
File path: superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx
##########
@@ -47,6 +48,14 @@ const sqlAdhocFilter = new AdhocFilter({
   clause: CLAUSES.WHERE,
 });
 
+const faultiAdhocFilter = new AdhocFilter({
+  expressionType: null,
+  subject: null,
+  operator: '>',
+  comparator: '10',
+  clause: CLAUSES.WHERE,
+});

Review comment:
       Nice catch, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org