You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/02 07:40:44 UTC

[GitHub] [incubator-echarts] dominic-simplan opened a new issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

dominic-simplan opened a new issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895


   ### Version
   4.8.0
   
   ### Reproduction link
   [https://echarts.apache.org/en/option.html#series-sankey.height](https://echarts.apache.org/en/option.html#series-sankey.height)
   
   ### Steps to reproduce
   Go here: https://echarts.apache.org/en/option.html#series-sankey.height, select "Try it" and change height to 100%. 
   "Oil reserves" and "Biofuel Imports" are not within the visible area anymore.
   
   ### What is expected?
   All nodes should be within the visible area at height = 100%
   
   ### What is actually happening?
   Some nodes are outside of the visible area at height = 100%
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] dominic-simplan commented on issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
dominic-simplan commented on issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895#issuecomment-653011924


   Okay so when setting the height i need to consider the current "top" value. Do I also need to consider the "bottom" value? Actually it seems like the "bottom" value doesn't have any effect. At least if I change it using "Try it", nothing in the diagram changes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] dominic-simplan edited a comment on issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
dominic-simplan edited a comment on issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895#issuecomment-653011924


   Okay so when setting the height i need to consider the current "top" value. Do I also need to consider the "bottom" value? Actually it seems like the "bottom" value doesn't have any effect. At least if I change it using "Try it", nothing in the diagram changes?
   
   Edit: "bottom" only seems to have an effect if I don't set the "height" attribute.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895#issuecomment-653004351


   You can set [`series-sankey.top`](https://echarts.apache.org/en/option.html#series-sankey.top) as `0` when `height` is `100%`. The default value of `top` is `5%`. The example provided in `Try it` panel doesn't set this option, so the chart may be overflow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] dominic-simplan closed issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
dominic-simplan closed issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895#issuecomment-652841928


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
   
   If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 🍵


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] dominic-simplan edited a comment on issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
dominic-simplan edited a comment on issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895#issuecomment-653011924


   Okay so when setting the height i need to consider the current "top" value. Do I also need to consider the "bottom" value? Actually it seems like the "bottom" value doesn't have any effect. At least if I change it using "Try it", nothing in the diagram changes?
   
   Edit: "bottom" only seems to have an effect if I don't set the "height" attribute.
   Thanks for your help!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart edited a comment on issue #12895: Sankey: Nodes are not within visible canvas if height is 100%

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #12895:
URL: https://github.com/apache/incubator-echarts/issues/12895#issuecomment-653004351


   You can set [`series-sankey.top`](https://echarts.apache.org/en/option.html#series-sankey.top) as `0` when `height` is `100%`. The default value of `top` is `5%`. The example provided in `Try it` panel doesn't set this option, so the chart may overflow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org