You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/26 15:47:21 UTC

[GitHub] [apisix] Firstsawyou opened a new issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line 

Firstsawyou opened a new issue #2860:
URL: https://github.com/apache/apisix/issues/2860


   ### Issue description
   
   1.Delete the semicolon after this line of code:
   [https://github.com/apache/apisix/blob/master/apisix/plugins/kafka-logger.lua#L26](https://github.com/apache/apisix/blob/master/apisix/plugins/kafka-logger.lua#L26)
   
   2.Two blank lines are required before the line of `return _M`๏ผš
   https://github.com/apache/apisix/blob/master/apisix/plugins/kafka-logger.lua#L185


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wfnuser commented on issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line

Posted by GitBox <gi...@apache.org>.
wfnuser commented on issue #2860:
URL: https://github.com/apache/apisix/issues/2860#issuecomment-734594408


   This one seems easy too. I would like to have a try!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2860:
URL: https://github.com/apache/apisix/issues/2860#issuecomment-734517958


   welcome PR ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Firstsawyou closed issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line

Posted by GitBox <gi...@apache.org>.
Firstsawyou closed issue #2860:
URL: https://github.com/apache/apisix/issues/2860


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on issue #2860: chore(kafka-logger): remove semicolon ";" and add blank line

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2860:
URL: https://github.com/apache/apisix/issues/2860#issuecomment-734728802


    That's nice๐Ÿ‘๐Ÿ‘


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org