[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2908: FINERACT-1840: Fee income is not realised if the loan got fully repaid

["josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #2908:
URL: https://github.com/apache/fineract/pull/2908#discussion_r1086619381


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3451,9 +3451,9 @@ private void handleLoanRepaymentInFull(final LocalDate transactionDate, final Lo
             }
         }
         if (isAllChargesPaid) {
+            this.closedOnDate = transactionDate;

Review Comment:
   I need to move the set of the `closedOnDate` value before the Life cycle machine method call because when the event listener was called It was in null at that moment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org