You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/03 06:30:26 UTC

[GitHub] [hudi] vingov opened a new pull request #3388: [HUDI-1985] favicon plus misc site fixes

vingov opened a new pull request #3388:
URL: https://github.com/apache/hudi/pull/3388


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   - Fixed favicon on the hudi.apache.org site.
   - Move the Our Vision Link to the top of the about footer menu.
   - Removed the last updated author and time for all the pages since it's showing my name for all the pages which are not correct plus removed the unnecessary CSS.
   - Fixed the Travis build to rebase before the merge.
   
   ## Brief change log
   
   - Fixed a bunch of minor issues on the hudi asf site.
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   Run these commands to test the site locally at http://localhost:3000/:
   Note: ensure you have npm installed
   
   ```
   ./website/scripts/build-site.sh
   cd website
   npm run serve
   ```
   Manually verified the website re-design changes by running the site locally.
   
   ## Committer checklist
   
    - [x] Has a corresponding JIRA in PR title & commit
    
    - [x] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] vingov commented on pull request #3388: [HUDI-1985] favicon plus misc site fixes

Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3388:
URL: https://github.com/apache/hudi/pull/3388#issuecomment-891973825


   @danny0405 - I will review and fix all the titles and send the PR soon, I preserved most of the original titles but that doesn't make sense with this new navigation links. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] vinothchandar merged pull request #3388: [HUDI-1985] favicon plus misc site fixes

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #3388:
URL: https://github.com/apache/hudi/pull/3388


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] vinothchandar commented on pull request #3388: [HUDI-1985] favicon plus misc site fixes

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3388:
URL: https://github.com/apache/hudi/pull/3388#issuecomment-891607466


   Missed your comment by a minute or so :( 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 commented on pull request #3388: [HUDI-1985] favicon plus misc site fixes

Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #3388:
URL: https://github.com/apache/hudi/pull/3388#issuecomment-891606132


   ![image](https://user-images.githubusercontent.com/7644508/127975204-3eef5979-f444-4807-ab92-59e313ce98f7.png)
   
   This also need fix: => Spark Guide


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org