You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/14 17:07:54 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #16230: [BEAM-13015] Update FakeBeamFnStateClient to generate elements that stop at the next block boundary instead of continuing into additional blocks.

lukecwik commented on a change in pull request #16230:
URL: https://github.com/apache/beam/pull/16230#discussion_r768873740



##########
File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/MultimapSideInputTest.java
##########
@@ -32,48 +36,58 @@
 /** Tests for {@link MultimapSideInput}. */
 @RunWith(JUnit4.class)
 public class MultimapSideInputTest {

Review comment:
       I swapped here to use bytes to ensure that we were performing comparisons using structural values and not based upon java equality.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org