You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/28 14:51:55 UTC
[GitHub] [kafka] sasukerui opened a new pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters
sasukerui opened a new pull request #8742:
URL: https://github.com/apache/kafka/pull/8742
I know this parameter will be used in the future, but it is not used here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-654436295
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-741650880
This PR may be invalid in trunk branch since ```zkClient``` is required ( see https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ConfigCommand.scala#L149)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-654486027
@sasukerui Can you please change the PR to target `master`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] sasukerui commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters
Posted by GitBox <gi...@apache.org>.
sasukerui commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-655474005
> @sasukerui Can you please change the PR to target `master`?
ok,l see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-636347366
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org