You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/16 21:30:38 UTC
[GitHub] [spark] viirya opened a new pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
viirya opened a new pull request #33401:
URL: https://github.com/apache/spark/pull/33401
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch removes an ignored test from `RocksDBSuite`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The removed test is now ignored. We have discussed about the test offline and it looks not making sense.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881803663
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141184/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881856613
@dongjoon-hyun Yea, thanks. Actually I should move the "we ..." out of the description.
Updated the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881772711
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881799643
**[Test build #141184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141184/testReport)** for PR 33401 at commit [`6bb6233`](https://github.com/apache/spark/commit/6bb6233b27ffd6827cc5f28d5a56ef921e0bc419).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881803663
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141184/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881734097
**[Test build #141184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141184/testReport)** for PR 33401 at commit [`6bb6233`](https://github.com/apache/spark/commit/6bb6233b27ffd6827cc5f28d5a56ef921e0bc419).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881862182
Jenkins passed. Merged to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33401:
URL: https://github.com/apache/spark/pull/33401#discussion_r671643401
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala
##########
@@ -337,69 +337,6 @@ class RocksDBSuite extends SparkFunSuite {
}
}
- ignore("ensure that concurrent update and cleanup consistent versions") {
- quietly {
- val numThreads = 20
- val numUpdatesInEachThread = 20
- val remoteDir = Utils.createTempDir().toString
- @volatile var exception: Exception = null
- val updatingThreads = Array.fill(numThreads) {
- new Thread() {
- override def run(): Unit = {
- try {
- for (version <- 0 to numUpdatesInEachThread) {
- withDB(
- remoteDir,
- version = version) { db =>
- val prevValue = Option(toStr(db.get("a"))).getOrElse("0").toInt
- db.put("a", (prevValue + 1).toString)
- db.commit()
- }
- }
- } catch {
- case e: Exception =>
- val newException = new Exception(s"ThreadId ${this.getId} failed", e)
- if (exception != null) {
Review comment:
First all, `exception` is null at beginning. So this condition will be never satisfied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881729466
cc @xuanyuanking If we don't need the test, I think we can just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881741226
cc @HeartSaVioR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881974736
Agree to delete this first.
Refer to https://github.com/apache/spark/pull/33220, even with the exception var fix, you may still found the test is flaky in Jenkins env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #33401:
URL: https://github.com/apache/spark/pull/33401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881956895
Thanks @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881772711
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881856613
@dongjoon-hyun Yea, thanks. Actually I should move the "we ..." out of the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881764771
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-882145547
Thanks for dealing with this, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881734097
**[Test build #141184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141184/testReport)** for PR 33401 at commit [`6bb6233`](https://github.com/apache/spark/commit/6bb6233b27ffd6827cc5f28d5a56ef921e0bc419).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33401: [SPARK-35785][SS][FOLLOWUP] Remove ignored test from RocksDBSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33401:
URL: https://github.com/apache/spark/pull/33401#issuecomment-881754346
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45696/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org