[GitHub] [helix] lei-xia commented on pull request #1227: Implement thread leakage check, fixing major thread leakage test and some flaky test

[GitBox <gi...@apache.org>]

lei-xia commented on pull request #1227:
URL: https://github.com/apache/helix/pull/1227#issuecomment-704425985


   This PR is too long for effective reviewing.  I scanned the PR quickly, I would suggest at least break it to 3 separate PRs with each of them focusing on just 1 topic, that will make them much easier to review:  1) Fix test issues caused by StateVerifier (i.e, add the delay),  2) Replace all hard-code sleep() call with TestVerifier, 3) Add ThreadLeak/memory usage check into the test, and maybe 4) other minor fixes in the tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org