You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2014/07/23 20:29:39 UTC
[jira] [Created] (MAPREDUCE-6000) native-task: Simplify
ByteBufferDataReader/Writer
Todd Lipcon created MAPREDUCE-6000:
--------------------------------------
Summary: native-task: Simplify ByteBufferDataReader/Writer
Key: MAPREDUCE-6000
URL: https://issues.apache.org/jira/browse/MAPREDUCE-6000
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
The ByteBufferDataReader and ByteBufferDataWriter class are more complex than necessary:
- several methods related to reading/writing strings and char arrays are implemented but never used by the native task code. Given that the use case for these classes is limited to serializing binary data to/from the native code, it seems unlikely people will want to use these methods in any performance-critical space. So, let's do simpler implementations that are less likely to be buggy, even if they're slightly less performant.
- methods like readLine() are even less likely to be used. Since it's a complex implementation, let's just throw UnsupportedOperationException
- in the test case, we can use Mockito to shorten the amount of new code
--
This message was sent by Atlassian JIRA
(v6.2#6252)