[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

[GitBox <gi...@apache.org>]

soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns
URL: https://github.com/apache/beam/pull/11415#discussion_r408430781
 
 

 ##########
 File path: website/src/documentation/patterns/side-inputs.md
 ##########
 @@ -50,25 +50,25 @@ For instance, the following code sample uses a `Map` to create a `DoFn`. The `Ma
 
 ## Slowly updating side input using windowing
 
-You can read side input pcollection periodically into distinct windows.
-Later, when you apply side input to your main input, windows will be matched automatically 1:1.
-This way, you can guarantee side input consistency on the duration of the single window.
-
-To do this, you can utilize PeriodicSequence PTransform that will generate infinite sequence
-of elements with some real-time period:
+You can read side input data periodically into distinct PCollection windows.
+Later, when you apply the side input to your main input, each main input
+window is automatically matched to a single side input window.
+This guarantees side input consistency on the duration of the single window,
+meaning that each window on main input side will be matched to a single
 
 Review comment:
   Missing "the" -> "on the main input"
   
   Present tense -> "is matched to a single..."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services