You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Mathias Herberts (JIRA)" <ji...@apache.org> on 2009/10/27 14:36:59 UTC
[jira] Created: (THRIFT-611) Under Windows when compiling using
MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
Under Windows when compiling using MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
-----------------------------------------------------------------------------------------------------
Key: THRIFT-611
URL: https://issues.apache.org/jira/browse/THRIFT-611
Project: Thrift
Issue Type: Bug
Affects Versions: 0.1, 0.2
Environment: Windows using MinGW
Reporter: Mathias Herberts
@see http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200909.mbox/%3C154c779e0909202245v727a7c26uf348b2b8af85e3c2@mail.gmail.com%3E
originally reported by Mark Smith who did not seem to want to file a JIRA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-611) Under Windows when compiling using
MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771037#action_12771037 ]
David Reiss commented on THRIFT-611:
------------------------------------
I think this should be wrapped in some sort of #ifdef, since '\\' is a valid (if somewhat insane) pathname character on Linux.
> Under Windows when compiling using MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
> -----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-611
> URL: https://issues.apache.org/jira/browse/THRIFT-611
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.1, 0.2
> Environment: Windows using MinGW
> Reporter: Mathias Herberts
> Attachments: mingw-slashes.patch
>
>
> @see http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200909.mbox/%3C154c779e0909202245v727a7c26uf348b2b8af85e3c2@mail.gmail.com%3E
> originally reported by Mark Smith who did not seem to want to file a JIRA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-611) Under Windows when compiling using
MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
Posted by "Mathias Herberts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771039#action_12771039 ]
Mathias Herberts commented on THRIFT-611:
-----------------------------------------
The replace is included in an #ifdef MINGW, the W standing for Windows I guess we'll avoir the Linux problem you mention.
> Under Windows when compiling using MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
> -----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-611
> URL: https://issues.apache.org/jira/browse/THRIFT-611
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.1, 0.2
> Environment: Windows using MinGW
> Reporter: Mathias Herberts
> Attachments: mingw-slashes.patch
>
>
> @see http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200909.mbox/%3C154c779e0909202245v727a7c26uf348b2b8af85e3c2@mail.gmail.com%3E
> originally reported by Mark Smith who did not seem to want to file a JIRA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-611) Under Windows when compiling using
MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771042#action_12771042 ]
David Reiss commented on THRIFT-611:
------------------------------------
Sorry, I only looked at the patch, not the surrounding code. This should be fine. Should we ask Mark to agree to the Apache License? He only sent a code snippet, not a patch.
> Under Windows when compiling using MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
> -----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-611
> URL: https://issues.apache.org/jira/browse/THRIFT-611
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.1, 0.2
> Environment: Windows using MinGW
> Reporter: Mathias Herberts
> Attachments: mingw-slashes.patch
>
>
> @see http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200909.mbox/%3C154c779e0909202245v727a7c26uf348b2b8af85e3c2@mail.gmail.com%3E
> originally reported by Mark Smith who did not seem to want to file a JIRA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-611) Under Windows when compiling using
MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
Posted by "Mathias Herberts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mathias Herberts updated THRIFT-611:
------------------------------------
Attachment: mingw-slashes.patch
> Under Windows when compiling using MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
> -----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-611
> URL: https://issues.apache.org/jira/browse/THRIFT-611
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.1, 0.2
> Environment: Windows using MinGW
> Reporter: Mathias Herberts
> Attachments: mingw-slashes.patch
>
>
> @see http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200909.mbox/%3C154c779e0909202245v727a7c26uf348b2b8af85e3c2@mail.gmail.com%3E
> originally reported by Mark Smith who did not seem to want to file a JIRA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-611) Under Windows when compiling using
MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-611.
--------------------------------
Assignee: Mathias Herberts
Fix Version/s: 0.3
Resolution: Fixed
I just committed this patch.
> Under Windows when compiling using MinGW, includes are incorrectly resolved due to '/' <-> '\' havoc.
> -----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-611
> URL: https://issues.apache.org/jira/browse/THRIFT-611
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.1, 0.2
> Environment: Windows using MinGW
> Reporter: Mathias Herberts
> Assignee: Mathias Herberts
> Fix For: 0.3
>
> Attachments: mingw-slashes.patch
>
>
> @see http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200909.mbox/%3C154c779e0909202245v727a7c26uf348b2b8af85e3c2@mail.gmail.com%3E
> originally reported by Mark Smith who did not seem to want to file a JIRA.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.