You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Tellier Benoit (JIRA)" <se...@james.apache.org> on 2017/06/21 08:05:00 UTC

[jira] [Closed] (JAMES-2063) NPE raised in SelectedMailboxImpl

     [ https://issues.apache.org/jira/browse/JAMES-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tellier Benoit closed JAMES-2063.
---------------------------------

> NPE raised in SelectedMailboxImpl
> ---------------------------------
>
>                 Key: JAMES-2063
>                 URL: https://issues.apache.org/jira/browse/JAMES-2063
>             Project: James Server
>          Issue Type: Bug
>          Components: IMAPServer
>    Affects Versions: master
>            Reporter: Tellier Benoit
>             Fix For: master
>
>
> In the constructor, SelectedMailboxImpl is added as a listener before being well initialized.
> {code:java}
> java.lang.NullPointerException: null
>     at org.apache.james.imap.processor.base.SelectedMailboxImpl.event(SelectedMailboxImpl.java:322)
>     at org.apache.james.mailbox.store.event.SynchronousEventDelivery.deliver(SynchronousEventDelivery.java:29)
>     at org.apache.james.mailbox.store.event.DefaultDelegatingMailboxListener.deliverEventToMailboxListeners(DefaultDelegatingMailboxListener.java:102)
>     at org.apache.james.mailbox.store.event.DefaultDelegatingMailboxListener.event(DefaultDelegatingMailboxListener.java:96)
>     at org.apache.james.mailbox.store.event.MailboxEventDispatcher.added(MailboxEventDispatcher.java:73)
>     at org.apache.james.mailbox.store.StoreMessageManager$6.execute(StoreMessageManager.java:663)
>     at org.apache.james.mailbox.store.StoreMessageManager$6.execute(StoreMessageManager.java:658)
>     at org.apache.james.mailbox.store.AbstractMailboxPathLocker.executeWithLock(AbstractMailboxPathLocker.java:38)
>     at org.apache.james.mailbox.store.StoreMessageManager.moveTo(StoreMessageManager.java:658)
>     at org.apache.james.mailbox.store.StoreMailboxManager$5.execute(StoreMailboxManager.java:682)
>     at org.apache.james.mailbox.store.MessageBatcher.batchMessages(MessageBatcher.java:52)
>     at org.apache.james.mailbox.store.StoreMailboxManager.moveMessages(StoreMailboxManager.java:680)
>     at org.apache.james.imap.processor.MoveProcessor.process(MoveProcessor.java:53)
>     at org.apache.james.imap.processor.AbstractMessageRangeProcessor.doProcess(AbstractMessageRangeProcessor.java:81)
>     at org.apache.james.imap.processor.AbstractMessageRangeProcessor.doProcess(AbstractMessageRangeProcessor.java:45)
>     at org.apache.james.imap.processor.AbstractMailboxProcessor.doProcess(AbstractMailboxProcessor.java:109)
>     at org.apache.james.imap.processor.AbstractMailboxProcessor.process(AbstractMailboxProcessor.java:96)
>     at org.apache.james.imap.processor.AbstractMailboxProcessor.doProcess(AbstractMailboxProcessor.java:88)
>     at org.apache.james.imap.processor.AbstractMailboxProcessor.doProcess(AbstractMailboxProcessor.java:71)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:54)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imap.processor.base.AbstractChainedProcessor.process(AbstractChainedProcessor.java:56)
>     at org.apache.james.imapserver.netty.ImapChannelUpstreamHandler.messageReceived(ImapChannelUpstreamHandler.java:200)
>     at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
>     at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
>     at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
>     at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
>     at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462)
>     at org.jboss.netty.handler.codec.frame.FrameDecoder.callDecode(FrameDecoder.java:443)
>     at org.jboss.netty.handler.codec.frame.FrameDecoder.messageReceived(FrameDecoder.java:303)
>     at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
>     at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
>     at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
>     at org.jboss.netty.handler.execution.ChannelUpstreamEventRunnable.doRun(ChannelUpstreamEventRunnable.java:43)
>     at org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:67)
>     at org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:314)
>     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>     at java.lang.Thread.run(Thread.java:745)
> {code}
>  - We need to initalize the UidMsnConverter, empty
>  - plug on the event system
>  - Load UIDs from the database (all), order them, and pass them in an "addAll" List<uid> method to UidMsnConverter. (This method locks, adds all the uids in the list, remove potential duplicates, then sort, then unlocks)
>  - Write unit tests for this addAll method
>  - Add mock test for SelectedMailboxImpl to demonstrate that (we can easilly delay UID retrieval with a mock, and force concurrency)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org