You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/15 01:14:33 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Zha0q1 opened a new pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147
Per @access2rohit 's suggestion creating this pr to update the variable names in the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r489117736
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
I think for generative ops maybe we can use `data`? For other ops I will definitely use `input` and `output`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
wkcn commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r493104353
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
`input` is a built-in function of python. I think `data` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r488444521
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
data -> input ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
wkcn commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r493104353
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
`input` is a built-in function in python. I think `data` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
wkcn commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r493104353
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
`input` is a built-in function of python. I think `data` is better.
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
@use_np
def test_ones():
- A = np.ones((INT_OVERFLOW, 2))
- assert A.shape == (INT_OVERFLOW, 2)
- assert A[0][0] == 1
+ data = np.ones((INT_OVERFLOW, 2))
Review comment:
`input` is a built-in function in python. I think `data` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 closed pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
Zha0q1 closed pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#issuecomment-692401444
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, sanity, clang, unix-cpu, centos-gpu, windows-gpu, website, centos-cpu, unix-gpu, edge, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org