You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/06/06 20:30:59 UTC
[jira] [Created] (MAPREDUCE-2568) Fix TestFileSystem
Fix TestFileSystem
------------------
Key: MAPREDUCE-2568
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: test
Affects Versions: 0.23.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045503#comment-13045503 ]
Daryn Sharp commented on MAPREDUCE-2568:
----------------------------------------
The findbugs failure is bogus. The TestMRCLI is not related to this patch, it is covered by MAPREDUCE-2565.
There's a reviewer +1 for the patch, so please considering committing this patch fixes the test it's intended to fix.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Jeffrey Naisbitt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045030#comment-13045030 ]
Jeffrey Naisbitt commented on MAPREDUCE-2568:
---------------------------------------------
+1 Looks good to me. Should we have a negative test that verifies the original testcase fails here, or do you already have that tested elsewhere?
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045552#comment-13045552 ]
Daryn Sharp commented on MAPREDUCE-2568:
----------------------------------------
Yes, I think you are right. I misspoke on the other jira because I didn't remember that a number of commands already used CommandFormat. I suspect people aren't going to be fond of losing the gnu permute behavior... Should I make permute be an option for CommandFormat with a default of on? It would have to be an option since all commands use CommandFormat now, and some like "test" cannot tolerate permute.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059121#comment-13059121 ]
Todd Lipcon commented on MAPREDUCE-2568:
----------------------------------------
Hi Daryn. Are you working on fixing this or we should reassign it? Thanks.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated MAPREDUCE-2568:
-----------------------------------
Attachment: MAPREDUCE-2568.patch
Move option earlier.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045527#comment-13045527 ]
Todd Lipcon commented on MAPREDUCE-2568:
----------------------------------------
actually, one question before commit: this test case has had this same ordering of arguments since it was introduced. It only started failing once we changed CommandFormat to only allow flags at the beginning. That indicates that the CommandFormat change was a compatibility-breaking change. Thoughts?
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045525#comment-13045525 ]
Todd Lipcon commented on MAPREDUCE-2568:
----------------------------------------
+1 looks good to me
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045244#comment-13045244 ]
Hadoop QA commented on MAPREDUCE-2568:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481604/MAPREDUCE-2568.patch
against trunk revision 1132807.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/353//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/353//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/353//console
This message is automatically generated.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045160#comment-13045160 ]
Daryn Sharp commented on MAPREDUCE-2568:
----------------------------------------
Good question. Yes, there are positive and negative tests in hadoop common. I question why MR is even testing a class ({{CommandFormat}}) that it doesn't "own"...
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045661#comment-13045661 ]
Todd Lipcon commented on MAPREDUCE-2568:
----------------------------------------
Yea, I guess making it optional makes the most sense. Default should probably be permutation is OK.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2568:
-----------------------------------
Status: Open (was: Patch Available)
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060621#comment-13060621 ]
Daryn Sharp commented on MAPREDUCE-2568:
----------------------------------------
Sorry for the delay, I've been out of town since last Thu. I am changing the parsing behavior to re-add the permute behavior and intend to close this jira as invalid.
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2568) Fix TestFileSystem
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated MAPREDUCE-2568:
-----------------------------------
Status: Patch Available (was: Open)
> Fix TestFileSystem
> ------------------
>
> Key: MAPREDUCE-2568
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2568
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: MAPREDUCE-2568.patch
>
>
> CommandFormat which is used to parse command lines is following posix conventions of stopping at the first non-argument. There is just one test in this file which placed an option in the middle of the args.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira