You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/23 04:30:41 UTC

[jira] [Commented] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

    [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155662#comment-13155662 ] 

jiraposter@reviews.apache.org commented on SQOOP-392:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Summary
-------

The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.

This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.


This addresses bug SQOOP-392.
    https://issues.apache.org/jira/browse/SQOOP-392


Diffs
-----

  /pom.xml 1205214 
  /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 

Diff: https://reviews.apache.org/r/2920/diff


Testing
-------

The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.

Also tested the build via ant - and all tests passed successfully.


Thanks,

Arvind


                
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira