[GitHub] [incubator-superset] betodealmeida opened a new pull request #8529: Encode feature flags to JSON pessimistically

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #8529: Encode feature flags to JSON pessimistically
URL: https://github.com/apache/incubator-superset/pull/8529
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   https://github.com/apache/incubator-superset/pull/8470 introduced a feature flag that is a function, for customizing the query cost estimate provided by different backend engines (currently supported only in Presto). The presence of a function in the feature flags breaks the JSON serialization of the payload, when sending it to the frontend.
   
   I fixed it by using the pessimistic JSON encoder, which fallbacks to a string representation of the object when the serialization fails.
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   I hit the error when deploying a custom feature flag, not sure why it wasn't triggered in https://github.com/apache/incubator-superset/pull/8470. Fixed it and verified it now works.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org