[jira] [Commented] (ARIES-1365) ServiceState attribute notifications slow down startup/shutdown time considerably

["David Bosschaert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655292#comment-14655292 ] 

David Bosschaert commented on ARIES-1365:
-----------------------------------------

I would simply add the possibility to disable to JMX attribute change notifications altogether. Not many people use this as far as I know. 

Personally I would just add some configuration that disables the notifications completely (so also for the BundleState).

> ServiceState attribute notifications slow down startup/shutdown time considerably
> ---------------------------------------------------------------------------------
>
>                 Key: ARIES-1365
>                 URL: https://issues.apache.org/jira/browse/ARIES-1365
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>    Affects Versions: jmx-core-1.1.3
>         Environment: org.apache.felix.framework 5.0.1
>            Reporter: Joel Richard
>              Labels: performance, shutdown, startup
>
> Around 20% of the startup time of our Felix OSGI container is spent creating attribute notifications for changed services in ServiceState#getAttributeChangeNotification. This is so slow because for each notification it calls bundleContext.getAllServiceReferences to get all service ids.
> Here a few suggestions how this could be improved:
> - The ServiceState could maintain its own list of service ids which is updated according to the service events
> - The ServiceState could implement the NotificationEmitter directly and be aware when there are any listeners (in our case, there are mostly none).
> - Make it possible to disable the attribute change notifications with configuration property.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)