You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/02 06:32:44 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #1172: Implement %ju/%jd printf format

yamt opened a new pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172


   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637348741


   @yamt thanks.
   
   Sometimes is hard to state the obvious but it may be usefull for others to understand the reason


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea merged pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637336329


   @yamt 
   https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
   
   It is a good advice for all commits not a rule for NuttX


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] yamt commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637335420


   @jerpelea where can i find the rule?
   i scanned "Code Contribution Workflow". but i failed to find it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] yamt commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637316710


   @jerpelea what's unclear to you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] yamt commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637344215


   @jerpelea 
   ok, i added some text.
   
   honestly speaking, i feel the original commit messages were good enough for this kind of obvious things though.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637323195


   Each commit should have title and commit message 
   Please add a small description according to the rule 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637312579


   please add commit messages 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1172: Implement %ju/%jd printf format

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1172:
URL: https://github.com/apache/incubator-nuttx/pull/1172#issuecomment-637336329


   @yamt 
   https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org