[GitHub] [superset] zhaoyongjie commented on a change in pull request #18171: fix: null and empty string in filter

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #18171:
URL: https://github.com/apache/superset/pull/18171#discussion_r792414274



##########
File path: superset/connectors/sqla/models.py
##########
@@ -756,9 +765,6 @@ def values_for_column(
         if limit:
             qry = qry.limit(limit)
 
-        if not contain_null:
-            qry = qry.where(target_col.get_sqla_col().isnot(None))
-

Review comment:
       These codes were introduced by this [PR](https://github.com/apache/superset/pull/17168). After we provide **replacing value** mechanism, this snippet is unused.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org