You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mf...@apache.org on 2016/07/05 20:47:33 UTC
svn commit: r1751555 - in /maven/plugins/trunk/maven-changes-plugin/src:
main/java/org/apache/maven/plugin/github/GitHubDownloader.java
test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java
Author: mfriedenhagen
Date: Tue Jul 5 20:47:33 2016
New Revision: 1751555
URL: http://svn.apache.org/viewvc?rev=1751555&view=rev
Log:
MCHANGES-371: github-report shows body of issue as summary.
This was introduced with MCHANGES-361.
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/github/GitHubDownloader.java
maven/plugins/trunk/maven-changes-plugin/src/test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/github/GitHubDownloader.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/github/GitHubDownloader.java?rev=1751555&r1=1751554&r2=1751555&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/github/GitHubDownloader.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/github/GitHubDownloader.java Tue Jul 5 20:47:33 2016
@@ -149,7 +149,7 @@ public class GitHubDownloader
issue.setTitle( githubIssue.getTitle() );
- issue.setSummary( githubIssue.getBody() );
+ issue.setSummary( githubIssue.getTitle() );
if ( githubIssue.getMilestone() != null )
{
Modified: maven/plugins/trunk/maven-changes-plugin/src/test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java?rev=1751555&r1=1751554&r2=1751555&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java Tue Jul 5 20:47:33 2016
@@ -49,7 +49,7 @@ public class GitHubDownloaderTestCase
assertEquals( Integer.toString( githubIssue.getNumber() ), issue.getId() );
assertEquals( Integer.toString( githubIssue.getNumber() ), issue.getKey() );
assertEquals( githubIssue.getTitle(), issue.getTitle() );
- assertEquals( githubIssue.getBody(), issue.getSummary() );
+ assertEquals( githubIssue.getTitle(), issue.getSummary() );
assertEquals( issueManagement.getUrl() + githubIssue.getNumber(), issue.getLink() );
}
}
Re: svn commit: r1751555 - in /maven/plugins/trunk/maven-changes-plugin/src:
main/java/org/apache/maven/plugin/github/GitHubDownloader.java test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java
Posted by Mirko Friedenhagen <mf...@gmail.com>.
After digging a bit deeper,
org.apache.maven.plugin.issues.Issue#getTitle is only referenced in
the changed GitHubDownloaderTestCase.
I changed the getter visibility to private (only test I had to adapt
was above GHDTC) and ran 'mvn -Prun-its clean verify' without issue.
In GH you may set a description for milestones (which have a title,
often used for version numbers), in JIRA you have fixVersions which
have a name (often used for version numbers) and a description.
We could probably just drop the issue title, but this would be a
breaking change, so I do not know wether it is worth it.
Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen)
https://bitbucket.org/mfriedenhagen/
On Sat, Jul 9, 2016 at 11:41 AM, Mirko Friedenhagen
<mf...@gmail.com> wrote:
> Hello Robert,
>
> firstly I just resurrected the state as it was before. The current
> changes-plugin-release does not output the "title" of GH issues
> anymore but the complete body which is not useable in a tabular
> output.
>
> I am a bit afraid, that there is a mismatch between JIRA and GitHub
> here. JIRA's summary is called title in GitHub.
>
> JIRA: https://issues.apache.org/jira/rest/api/2/issue/MCHANGES-371?fields=summary,description
> GH: https://api.github.com/repos/mojohaus/versions-maven-plugin/issues/95
>
> So we have:
> GitHub title corresponds to JIRA summary
> GitHub body corresponds to JIRA description
>
> I will take another look.
> Regards Mirko
> --
> http://illegalstateexception.blogspot.com/
> https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen)
> https://bitbucket.org/mfriedenhagen/
>
>
> On Wed, Jul 6, 2016 at 6:43 PM, Robert Scholte <rf...@apache.org> wrote:
>> On Tue, 05 Jul 2016 22:47:33 +0200, <mf...@apache.org> wrote:
>>
>>> assertEquals( githubIssue.getTitle(), issue.getTitle() );
>>> - assertEquals( githubIssue.getBody(), issue.getSummary() );
>>> + assertEquals( githubIssue.getTitle(), issue.getSummary() );
>>
>>
>> This looks weird to me: this can only be true in issue.getTitle() and
>> issue.getSummary() are the same.
>> Are you sure that the problem is here and not in the report?
>>
>> Robert
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1751555 - in /maven/plugins/trunk/maven-changes-plugin/src:
main/java/org/apache/maven/plugin/github/GitHubDownloader.java test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java
Posted by Mirko Friedenhagen <mf...@gmail.com>.
Hello Robert,
firstly I just resurrected the state as it was before. The current
changes-plugin-release does not output the "title" of GH issues
anymore but the complete body which is not useable in a tabular
output.
I am a bit afraid, that there is a mismatch between JIRA and GitHub
here. JIRA's summary is called title in GitHub.
JIRA: https://issues.apache.org/jira/rest/api/2/issue/MCHANGES-371?fields=summary,description
GH: https://api.github.com/repos/mojohaus/versions-maven-plugin/issues/95
So we have:
GitHub title corresponds to JIRA summary
GitHub body corresponds to JIRA description
I will take another look.
Regards Mirko
--
http://illegalstateexception.blogspot.com/
https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen)
https://bitbucket.org/mfriedenhagen/
On Wed, Jul 6, 2016 at 6:43 PM, Robert Scholte <rf...@apache.org> wrote:
> On Tue, 05 Jul 2016 22:47:33 +0200, <mf...@apache.org> wrote:
>
>> assertEquals( githubIssue.getTitle(), issue.getTitle() );
>> - assertEquals( githubIssue.getBody(), issue.getSummary() );
>> + assertEquals( githubIssue.getTitle(), issue.getSummary() );
>
>
> This looks weird to me: this can only be true in issue.getTitle() and
> issue.getSummary() are the same.
> Are you sure that the problem is here and not in the report?
>
> Robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1751555 - in
/maven/plugins/trunk/maven-changes-plugin/src:
main/java/org/apache/maven/plugin/github/GitHubDownloader.java
test/java/org/apache/maven/plugin/github/GitHubDownloaderTestCase.java
Posted by Robert Scholte <rf...@apache.org>.
On Tue, 05 Jul 2016 22:47:33 +0200, <mf...@apache.org> wrote:
> assertEquals( githubIssue.getTitle(), issue.getTitle() );
> - assertEquals( githubIssue.getBody(), issue.getSummary() );
> + assertEquals( githubIssue.getTitle(), issue.getSummary() );
This looks weird to me: this can only be true in issue.getTitle() and
issue.getSummary() are the same.
Are you sure that the problem is here and not in the report?
Robert
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org