You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/27 22:30:38 UTC

[GitHub] [tvm] mehrdadh opened a new pull request #8154: [microTVM] make RVM memory and number of cores variable

mehrdadh opened a new pull request #8154:
URL: https://github.com/apache/tvm/pull/8154


   With this change we can set the memory size and number of cores for RVM with `vagrant up` command. I kept default values for them so that we don't require to change the tutorials.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mehrdadh commented on a change in pull request #8154: [microTVM] make RVM memory and number of cores variable

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on a change in pull request #8154:
URL: https://github.com/apache/tvm/pull/8154#discussion_r641827022



##########
File path: apps/microtvm/reference-vm/zephyr/Vagrantfile
##########
@@ -18,6 +18,18 @@
 Vagrant.configure("2") do |config|
   config.vm.box = "tlcpack/microtvm-zephyr-2.5"
 
+  if ENV.has_key?("RVM_NUM_CORES")

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] areusch commented on a change in pull request #8154: [microTVM] make RVM memory and number of cores variable

Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8154:
URL: https://github.com/apache/tvm/pull/8154#discussion_r641806673



##########
File path: apps/microtvm/reference-vm/zephyr/Vagrantfile
##########
@@ -18,6 +18,18 @@
 Vagrant.configure("2") do |config|
   config.vm.box = "tlcpack/microtvm-zephyr-2.5"
 
+  if ENV.has_key?("RVM_NUM_CORES")

Review comment:
       maybe we want to prefix all env vars with TVM_?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mehrdadh commented on pull request #8154: [microTVM] make RVM memory and number of cores variable

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8154:
URL: https://github.com/apache/tvm/pull/8154#issuecomment-849983774


   cc @areusch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] areusch merged pull request #8154: [microTVM] make RVM memory and number of cores variable

Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8154:
URL: https://github.com/apache/tvm/pull/8154


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org