You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/22 08:35:04 UTC

[GitHub] [iotdb] wshao08 commented on a change in pull request #1657: Fix for Codesmell check step1

wshao08 commented on a change in pull request #1657:
URL: https://github.com/apache/iotdb/pull/1657#discussion_r509979080



##########
File path: server/src/test/java/org/apache/iotdb/db/sync/receiver/recover/SyncReceiverLogAnalyzerTest.java
##########
@@ -22,14 +22,15 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
+import com.google.common.primitives.Ints;

Review comment:
       Fixed

##########
File path: server/src/test/java/org/apache/iotdb/db/sync/receiver/load/FileLoaderTest.java
##########
@@ -22,15 +22,16 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
+import com.google.common.primitives.Ints;

Review comment:
       Fixed

##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBFlushQueryMergeIT.java
##########
@@ -93,11 +95,14 @@ public void selectAllSQLTest() throws ClassNotFoundException {
       boolean hasResultSet = statement.execute("SELECT * FROM root");
       Assert.assertTrue(hasResultSet);
 
-      try (ResultSet resultSet = statement.getResultSet()) {
+      ResultSet resultSet = statement.getResultSet();

Review comment:
       Fixed

##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBClearCacheIT.java
##########
@@ -36,6 +36,8 @@
 import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Test;
+import org.slf4j.Logger;

Review comment:
       Fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org