You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/10/25 13:54:00 UTC

[jira] [Commented] (NIFI-6798) Validate Controller Services referenced via dynamic properties

    [ https://issues.apache.org/jira/browse/NIFI-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959775#comment-16959775 ] 

ASF subversion and git services commented on NIFI-6798:
-------------------------------------------------------

Commit 81fc2768c9d6cb61be10ba5adc805517c29816c7 in nifi's branch refs/heads/master from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=81fc276 ]

NIFI-6798: When checking that referenced Controller Services are valid, use ValidationContext.getProperties() rather than ComponentNode.getSupportedPropertyDescriptors() because the latter does not include dynamic properties

This closes #3836.

Signed-off-by: Bryan Bende <bb...@apache.org>


> Validate Controller Services referenced via dynamic properties
> --------------------------------------------------------------
>
>                 Key: NIFI-6798
>                 URL: https://issues.apache.org/jira/browse/NIFI-6798
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Peter Turcsanyi
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If a Controller Service referenced by another component is disabled, then the referencing component should be in invalid state.
> It works fine for statically referenced Controller Services (configured via static properties of the processor / another service), but it seems the framework does not check it for dynamically configured services.
> The validator method can be found here:
> [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java#L679]
> Components that have Controller Service references configured via dynamic properties:
>  * DBCPConnectionPoolLookup
>  * AzureStorageCredentialsControllerServiceLookup
>  * (there might be others, needs to be checked)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)