You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@predictionio.apache.org by anothermh <gi...@git.apache.org> on 2017/09/16 07:23:41 UTC

[GitHub] incubator-predictionio-sdk-ruby pull request #22: Add support for Ruby 2.4

GitHub user anothermh opened a pull request:

    https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22

    Add support for Ruby 2.4

    This PR updates the versions of rspec and webmock to support Ruby 2.4, and relaxes the version constraint on the json gem to allow 2.x versions that are required for Ruby 2.4.
    
    I tried checking [here](https://predictionio.atlassian.net/browse/SDKRUBY) for an open issue about this, but the Atlassian site repeatedly says the board isn't available.
    
    If this PR is accepted then it would be great if someone could please cut a new release on rubygems. (although the version should go from 0.9.x to 0.10.x if you're dropping support for Ruby 1.9.3, which the current `develop` branch does)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anothermh/incubator-predictionio-sdk-ruby develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit bc148c9b2c87971f2f6b007c0f21494d39721ad9
Author: anothermh <an...@users.noreply.github.com>
Date:   2017-09-16T07:08:33Z

    Add support for Ruby 2.4

commit 722d0938620435a0c2691ec0d28682f6187ee877
Author: anothermh <an...@users.noreply.github.com>
Date:   2017-09-16T07:08:56Z

    Add support for Ruby 2.4

commit 43b8d6bc0b22a2bd4fd863c335f024c7ac795a2a
Author: anothermh <an...@users.noreply.github.com>
Date:   2017-09-16T07:09:43Z

    Add support for Ruby 2.4

----


---

[GitHub] incubator-predictionio-sdk-ruby issue #22: Add support for Ruby 2.4

Posted by dszeto <gi...@git.apache.org>.

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22
  
    I am going to merge this and make a new release. Thanks @anothermh !


---

[GitHub] incubator-predictionio-sdk-ruby issue #22: Add support for Ruby 2.4

Posted by ifokeev <gi...@git.apache.org>.

Github user ifokeev commented on the issue:

    https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22
  
    up


---

[GitHub] incubator-predictionio-sdk-ruby pull request #22: Add support for Ruby 2.4

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22


---

[GitHub] incubator-predictionio-sdk-ruby issue #22: Add support for Ruby 2.4

Posted by dszeto <gi...@git.apache.org>.

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22
  
    Thanks for fixing this, @anothermh ! Sorry that the contribution guide is outdated. I will update it. Meanwhile, please follow https://github.com/apache/incubator-predictionio/blob/develop/CONTRIBUTING.md and create a ticket with component `Ruby SDK` to describe this.


---