[GitHub] [iceberg] xloya commented on a change in pull request #3563: Spark: Rewrite if no commit succeeded throw commit failed exception

[GitBox <gi...@apache.org>]

xloya commented on a change in pull request #3563:
URL: https://github.com/apache/iceberg/pull/3563#discussion_r750827933



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
##########
@@ -327,6 +327,7 @@ private Result doExecuteWithPartialProgress(RewriteExecutionContext ctx, Stream<
       LOG.error("{} is true but no rewrite commits succeeded. Check the logs to determine why the individual " +
           "commits failed. If this is persistent it may help to increase {} which will break the rewrite operation " +
           "into smaller commits.", PARTIAL_PROGRESS_ENABLED, PARTIAL_PROGRESS_MAX_COMMITS);
+      throw new CommitFailedException("No rewrite commits succeeded after max commits");

Review comment:
       Hey, @RussellSpitzer thanks for your review! I got your point, I think we can throw a new NoCommitSucceedException which extends RuntimeException here. What do you think of this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org