You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/16 08:25:26 UTC
[GitHub] [incubator-nuttx] teknokita opened a new pull request, #7110: add include to esp32c3_usbserial.c
teknokita opened a new pull request, #7110:
URL: https://github.com/apache/incubator-nuttx/pull/7110
undeclare TCGETS on esp32c3 when enable usbserial and termios error:
chip/esp32c3_usbserial.c: In function 'esp32c3_ioctl':
chip/esp32c3_usbserial.c:411:10: error: 'TCGETS' undeclared (first use in this function)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7110: add include to esp32c3_usbserial.c
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7110:
URL: https://github.com/apache/incubator-nuttx/pull/7110#discussion_r973078993
##########
arch/risc-v/src/esp32c3/esp32c3_usbserial.c:
##########
@@ -32,6 +32,7 @@
#ifdef CONFIG_SERIAL_TERMIOS
# include <termios.h>
+#include <nuttx/fs/ioctl.h>
Review Comment:
```suggestion
# include <nuttx/fs/ioctl.h>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7110: add include to esp32c3_usbserial.c
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7110:
URL: https://github.com/apache/incubator-nuttx/pull/7110#issuecomment-1249216141
@teknokita
Please squash the two commits into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7110: add include to esp32c3_usbserial.c
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7110:
URL: https://github.com/apache/incubator-nuttx/pull/7110#discussion_r972756130
##########
arch/risc-v/src/esp32c3/esp32c3_usbserial.c:
##########
@@ -32,6 +32,7 @@
#ifdef CONFIG_SERIAL_TERMIOS
# include <termios.h>
+#include <nuttx/fs/ioctl.h>
Review Comment:
add two space like termios.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7110: add include to esp32c3_usbserial.c
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7110:
URL: https://github.com/apache/incubator-nuttx/pull/7110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org