You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "nick-boss-tech (via GitHub)" <gi...@apache.org> on 2026/09/30 02:18:51 UTC
[PR] SOLR-18178: Fix configset archive path handling [solr]
nick-boss-tech opened a new pull request, #4968:
URL: https://github.com/apache/solr/pull/4968
Configset archive handling built ZIP entry names with OS-native path separators, so archives produced on Windows carried backslash entry names that broke on extraction (`UploadConfigSet`).
This normalizes archive entry names to forward slashes everywhere:
- new `DownloadConfigSet.toZipEntryName` builds ZIP-legal entry names (`/` separators, no leading slash, directories get a trailing slash);
- `UploadConfigSet` extraction and `FileSystemConfigSetService` directory listing use the same normalization.
Tests:
- new `DownloadConfigSetAPITest` / `UploadConfigSetAPITest` cases cover archives containing subdirectories;
- `TestFileSystemConfigSetService` and `TestSchemaDesignerConfigSetHelper` updated accordingly.
Changelog: `changelog/unreleased/SOLR-18178.yml` (fixed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18178: Fix configset archive path handling [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4968:
URL: https://github.com/apache/solr/pull/4968#issuecomment-6027812077
Thanks for testing @malliaridis!!!
I think I lean towards failing the upload. The end user won’t see the logged errors, only some poor ops person days later who is then wondering what happened. Also if we do this filtering maybe in the future we also filter something someone needs? Just feels like the least surprising thing is to fail if you have weird files??!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18178: Fix configset archive path handling [solr]
Posted by "nick-boss-tech (via GitHub)" <gi...@apache.org>.
nick-boss-tech commented on PR #4968:
URL: https://github.com/apache/solr/pull/4968#issuecomment-6460799637
I rebased and simplified the PR description. Self-review passes.
@epugh @malliaridis could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18178: Fix configset archive path handling [solr]
Posted by "nick-boss-tech (via GitHub)" <gi...@apache.org>.
nick-boss-tech commented on PR #4968:
URL: https://github.com/apache/solr/pull/4968#issuecomment-6028912336
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)*
I lean the same way. Failing also makes the zip path consistent with `uploadConfigSetFile`, which already rejects an unsafe path with a 400 rather than skipping it. Pushed: the upload now validates every entry name before anything is written, so one unsafe entry fails the whole upload with a 400 and nothing is stored. The tests, the ref guide note, and the changelog entry are updated to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org