You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/09/11 05:33:58 UTC
[GitHub] [incubator-echarts] 100pah commented on a change in pull request
#11213: Fix dataStack work incorrectly with dataZoom
100pah commented on a change in pull request #11213: Fix dataStack work incorrectly with dataZoom
URL: https://github.com/apache/incubator-echarts/pull/11213#discussion_r323065249
##########
File path: src/chart/tree/TreeView.js
##########
@@ -161,6 +161,8 @@ export default echarts.extendChartView({
var max = [];
bbox.fromPoints(points, min, max);
+ // Store min max because when collapse the root node after roam,
+ // the root node will disappear.
Review comment:
This comment might be ambiguous for the reader.
Probably we should describe it like: if we dont store min/max, the root will disappear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org