You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alexander Denissov <ad...@apache.org> on 2016/03/15 23:51:56 UTC
Review Request 44868: Changed HAWQ directory descriptions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-15433
https://issues.apache.org/jira/browse/AMBARI-15433
Repository: ambari
Description
-------
Changed HAWQ directory descriptions
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml d3aa0ed
Diff: https://reviews.apache.org/r/44868/diff/
Testing
-------
manual.
Thanks,
Alexander Denissov
Re: Review Request 44868: Changed HAWQ directory descriptions
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/#review123918
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On March 15, 2016, 10:51 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44868/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 10:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15433
> https://issues.apache.org/jira/browse/AMBARI-15433
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed HAWQ directory descriptions
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml d3aa0ed
>
> Diff: https://reviews.apache.org/r/44868/diff/
>
>
> Testing
> -------
>
> manual.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 44868: Changed HAWQ directory descriptions
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/#review123818
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml (line 121)
<https://reviews.apache.org/r/44868/#comment186104>
```
... temp directories is equal ...
```
as 1. use "directories" instead of "dirs" and 2. "is" instead of "are" as it is a verb of "the recommended number"?
Sorry this is trivial but since you are enhancing the description.
- jun aoki
On March 15, 2016, 10:51 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44868/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 10:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15433
> https://issues.apache.org/jira/browse/AMBARI-15433
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed HAWQ directory descriptions
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml d3aa0ed
>
> Diff: https://reviews.apache.org/r/44868/diff/
>
>
> Testing
> -------
>
> manual.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 44868: Changed HAWQ directory descriptions
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/#review123779
-----------------------------------------------------------
Ship it!
Ship It!
- Goutam Tadi
On March 15, 2016, 10:51 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44868/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 10:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15433
> https://issues.apache.org/jira/browse/AMBARI-15433
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed HAWQ directory descriptions
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml d3aa0ed
>
> Diff: https://reviews.apache.org/r/44868/diff/
>
>
> Testing
> -------
>
> manual.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 44868: Changed HAWQ directory descriptions
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/#review123784
-----------------------------------------------------------
Ship it!
Ship It!
- Lav Jain
On March 15, 2016, 10:51 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44868/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 10:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15433
> https://issues.apache.org/jira/browse/AMBARI-15433
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed HAWQ directory descriptions
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml d3aa0ed
>
> Diff: https://reviews.apache.org/r/44868/diff/
>
>
> Testing
> -------
>
> manual.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 44868: Changed HAWQ directory descriptions
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/
-----------------------------------------------------------
(Updated March 16, 2016, 10:42 p.m.)
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Oleksandr Diachenko, and Sumit Mohanty.
Changes
-------
updated description sentences
Bugs: AMBARI-15433
https://issues.apache.org/jira/browse/AMBARI-15433
Repository: ambari
Description
-------
Changed HAWQ directory descriptions
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml d3aa0ed
Diff: https://reviews.apache.org/r/44868/diff/
Testing
-------
manual.
Thanks,
Alexander Denissov