You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by ag...@apache.org on 2007/06/08 20:11:30 UTC
svn commit: r545577 - in /roller/trunk/apps/weblogger/web/WEB-INF/jsps:
admin/GlobalCommentManagement.jsp editor/Comments.jsp
Author: agilliland
Date: Fri Jun 8 11:11:29 2007
New Revision: 545577
URL: http://svn.apache.org/viewvc?view=rev&rev=545577
Log:
fixing javascript bug which was causing the select all/none buttons on comment management pages to not work properly.
Modified:
roller/trunk/apps/weblogger/web/WEB-INF/jsps/admin/GlobalCommentManagement.jsp
roller/trunk/apps/weblogger/web/WEB-INF/jsps/editor/Comments.jsp
Modified: roller/trunk/apps/weblogger/web/WEB-INF/jsps/admin/GlobalCommentManagement.jsp
URL: http://svn.apache.org/viewvc/roller/trunk/apps/weblogger/web/WEB-INF/jsps/admin/GlobalCommentManagement.jsp?view=diff&rev=545577&r1=545576&r2=545577
==============================================================================
--- roller/trunk/apps/weblogger/web/WEB-INF/jsps/admin/GlobalCommentManagement.jsp (original)
+++ roller/trunk/apps/weblogger/web/WEB-INF/jsps/admin/GlobalCommentManagement.jsp Fri Jun 8 11:11:29 2007
@@ -21,11 +21,12 @@
<script type="text/javascript">
<!--
function setChecked(val, name) {
- len = document.globalCommentManagement.elements.length;
+ form = $('globalCommentManagement');
+ len = form.elements.length;
var i=0;
for( i=0 ; i<len ; i++) {
- if (document.globalCommentManagement.elements[i].name == name) {
- document.globalCommentManagement.elements[i].checked=val;
+ if (form.elements[i].name == name) {
+ form.elements[i].checked=val;
}
}
}
@@ -193,19 +194,19 @@
<td align="center">
<s:text name="commentManagement.select" /><br/>
- <a href="#" onclick='setChecked(1,"spamComments")'>
+ <a href="#" onclick='setChecked(1,"bean.spamComments")'>
<s:text name="commentManagement.all" /></a><br />
- <a href="#" onclick='setChecked(0,"spamComments")'>
+ <a href="#" onclick='setChecked(0,"bean.spamComments")'>
<s:text name="commentManagement.none" /></a>
</td>
<td align="center">
<s:text name="commentManagement.select" /><br/>
- <a href="#" onclick='setChecked(1,"deleteComments")'>
+ <a href="#" onclick='setChecked(1,"bean.deleteComments")'>
<s:text name="commentManagement.all" /></a><br />
- <a href="#" onclick='setChecked(0,"deleteComments")'>
+ <a href="#" onclick='setChecked(0,"bean.deleteComments")'>
<s:text name="commentManagement.none" /></a>
</td>
<td align="right">
@@ -268,7 +269,7 @@
<s:text name="commentManagement.commentByBoth" >
<s:param><s:property value="#comment.name" /></s:param>
<s:param><s:property value="#comment.email" /></s:param>
- <s:param value="mailto" />
+ <s:param><s:property value="#comment.email" /></s:param>
<s:param><s:property value="#comment.remoteHost" /></s:param>
</s:text>
</s:if>
Modified: roller/trunk/apps/weblogger/web/WEB-INF/jsps/editor/Comments.jsp
URL: http://svn.apache.org/viewvc/roller/trunk/apps/weblogger/web/WEB-INF/jsps/editor/Comments.jsp?view=diff&rev=545577&r1=545576&r2=545577
==============================================================================
--- roller/trunk/apps/weblogger/web/WEB-INF/jsps/editor/Comments.jsp (original)
+++ roller/trunk/apps/weblogger/web/WEB-INF/jsps/editor/Comments.jsp Fri Jun 8 11:11:29 2007
@@ -21,11 +21,12 @@
<script type="text/javascript">
<!--
function setChecked(val, name) {
- len = document.globalCommentManagement.elements.length;
+ form = $('comments');
+ len = form.elements.length;
var i=0;
for( i=0 ; i<len ; i++) {
- if (document.globalCommentManagement.elements[i].name == name) {
- document.globalCommentManagement.elements[i].checked=val;
+ if (form.elements[i].name == name) {
+ form.elements[i].checked=val;
}
}
}
@@ -199,28 +200,28 @@
<td align="center">
<s:text name="commentManagement.select" /><br/>
- <a href="#" onclick='setChecked(1,"approvedComments")'>
+ <a href="#" onclick='setChecked(1,"bean.approvedComments")'>
<s:text name="commentManagement.all" /></a><br />
- <a href="#" onclick='setChecked(0,"approvedComments")'>
+ <a href="#" onclick='setChecked(0,"bean.approvedComments")'>
<s:text name="commentManagement.none" /></a>
</td>
<td align="center">
<s:text name="commentManagement.select" /><br/>
- <a href="#" onclick='setChecked(1,"spamComments")'>
+ <a href="#" onclick='setChecked(1,"bean.spamComments")'>
<s:text name="commentManagement.all" /></a><br />
- <a href="#" onclick='setChecked(0,"spamComments")'>
+ <a href="#" onclick='setChecked(0,"bean.spamComments")'>
<s:text name="commentManagement.none" /></a>
</td>
<td align="center">
<s:text name="commentManagement.select" /><br/>
- <a href="#" onclick='setChecked(1,"deleteComments")'>
+ <a href="#" onclick='setChecked(1,"bean.deleteComments")'>
<s:text name="commentManagement.all" /></a><br />
- <a href="#" onclick='setChecked(0,"deleteComments")'>
+ <a href="#" onclick='setChecked(0,"bean.deleteComments")'>
<s:text name="commentManagement.none" /></a>
</td>
<td align="right">
@@ -288,7 +289,7 @@
<s:text name="commentManagement.commentByBoth" >
<s:param><s:property value="#comment.name" /></s:param>
<s:param><s:property value="#comment.email" /></s:param>
- <s:param value="mailto" />
+ <s:param><s:property value="#comment.email" /></s:param>
<s:param><s:property value="#comment.remoteHost" /></s:param>
</s:text>
</s:if>