You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2026/08/13 04:57:41 UTC
[PR] ci: add vcpkg/Windows ARM pipeline for CMake build [arrow-adbc]
lidavidm opened a new pull request, #4686:
URL: https://github.com/apache/arrow-adbc/pull/4686
Closes #4860.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add vcpkg/Windows ARM pipeline for CMake build [arrow-adbc]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4686:
URL: https://github.com/apache/arrow-adbc/pull/4686#discussion_r3773327467
##########
.github/workflows/native-vcpkg.yml:
##########
@@ -0,0 +1,129 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Native Libraries (vcpkg)
+
+on:
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "c/**"
+ - "ci/**"
+ - "glib/**"
+ - "go/**"
+ - "python/**"
+ - "ruby/**"
+ - ".github/workflows/native-windows.yml"
+ push:
+ branches-ignore:
+ - 'dependabot/**'
+ paths:
+ - "c/**"
+ - "ci/**"
+ - "glib/**"
+ - "go/**"
+ - "python/**"
+ - "ruby/**"
+ - ".github/workflows/native-windows.yml"
+ workflow_call:
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }}-vcpkg
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+defaults:
+ run:
+ shell: pwsh
+
+jobs:
+ drivers-vcpkg:
+ name: "C/C++ (${{ matrix.os }}/${{ matrix.config }})"
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ include:
+ - { os: windows-latest, arch: x64, config: debug, msystem: UCRT64, env: x86_64, triplet: x64-windows }
+ - { os: windows-latest, arch: x64, config: release, msystem: UCRT64, env: x86_64, triplet: x64-windows }
+ - { os: windows-11-arm, arch: arm64, config: release, msystem: CLANGARM64, env: clang-aarch64, triplet: arm64-windows-release }
+ env:
+ VCPKG_DEFAULT_BINARY_CACHE: ${{ github.workspace }}/vcpkg-cache
+ VCPKG_DEFAULT_TRIPLET: ${{ matrix.triplet }}
+ VCPKG_ROOT: ${{ github.workspace }}/vcpkg
+ steps:
+ - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2.32.0
+ id: msys2
+ with:
+ msystem: ${{ matrix.msystem }}
+ update: true
+ # Needed for gendef tool in GoUtils.cmake
+ install: |
+ mingw-w64-${{ matrix.env }}-tools
+ - name: Add CLANGARM64 toolchain to PATH
+ env:
+ MSYS_LOCATION: ${{ steps.msys2.outputs.msys2-location }}
+ run: |
+ "$($env:MSYS_LOCATION)\clangarm64\bin" |
+ Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
Review Comment:
This step runs for every matrix entry but exports only `clangarm64\bin`. In the x64 jobs, `mingw-w64-x86_64-tools` installs `gendef`/`dlltool` under `mingw64\bin`, so `GoUtils.cmake` cannot find them and silently omits the Go import libraries. Export the directory matching each architecture.
##########
.github/workflows/native-vcpkg.yml:
##########
@@ -0,0 +1,129 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Native Libraries (vcpkg)
+
+on:
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "c/**"
+ - "ci/**"
+ - "glib/**"
+ - "go/**"
+ - "python/**"
+ - "ruby/**"
+ - ".github/workflows/native-windows.yml"
Review Comment:
This new workflow watches `native-windows.yml` instead of itself. A pull request that changes only `native-vcpkg.yml` will skip these checks, so the workflow's own path must be listed here.
This issue also appears on line 42 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Windows on ARM + vcpkg pipeline [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4686:
URL: https://github.com/apache/arrow-adbc/pull/4686#discussion_r3848363956
##########
ci/vcpkg/triplets/arm64-windows-release.cmake:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(VCPKG_TARGET_ARCHITECTURE arm64)
+set(VCPKG_CRT_LINKAGE dynamic)
+set(VCPKG_LIBRARY_LINKAGE dynamic)
Review Comment:
Ah right. I think the triplet needs to be renamed too then, I'll update this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Windows on ARM + vcpkg pipeline [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4686:
URL: https://github.com/apache/arrow-adbc/pull/4686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add Windows on ARM + vcpkg pipeline [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #4686:
URL: https://github.com/apache/arrow-adbc/pull/4686#discussion_r3846980360
##########
ci/vcpkg/triplets/arm64-windows-release.cmake:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(VCPKG_TARGET_ARCHITECTURE arm64)
+set(VCPKG_CRT_LINKAGE dynamic)
+set(VCPKG_LIBRARY_LINKAGE dynamic)
Review Comment:
We want static here, no? Or did you just want dynamic for tests?
```suggestion
set(VCPKG_LIBRARY_LINKAGE static)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org