[jira] [Commented] (GROOVY-7948) tab completion for static imports in groovysh does not work

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549618#comment-15549618 ] 

ASF GitHub Bot commented on GROOVY-7948:
----------------------------------------

GitHub user heenenee opened a pull request:

    https://github.com/apache/groovy/pull/438

    GROOVY-7948: fix completion of static imports in groovysh

    Fixed completion of static imports; updated unit tests; did some refactorings in ImportsSyntaxCompletor; added comment explaining how imports are stored in Groovysh.  Also did some manual testing of completion functionality using groovysh.bat in a cleanly built binary distribution.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heenenee/groovy GROOVY-7948

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/438.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #438
    
----
commit ff0a7208949a2d32a5be9732383436b98a36eb27
Author: Abraham Grief <ab...@gmail.com>
Date:   2016-10-05T18:32:43Z

    GROOVY-7948: fix completion of static imports in groovysh

----


> tab completion for static imports in groovysh does not work
> -----------------------------------------------------------
>
>                 Key: GROOVY-7948
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7948
>             Project: Groovy
>          Issue Type: Bug
>          Components: Groovysh
>    Affects Versions: 2.4.7
>            Reporter: Abraham Grief
>
> Currently, if I run groovysh, and enter the following:
> {noformat}
> class MyMath {
>     static int square(int x) {return x*x}
> }
> import static MyMath.*
> {noformat}
> Then enter {noformat}sq{noformat} followed by hitting the Tab key, groovysh does not provided any possible auto-completions.
> Instead, hitting the Tab key should auto-complete to the square method in MyMath.
> I fixed this already in my local groovy installation and can submit it as a pull request if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)