[GitHub] [cordova-ios] rollinq commented on pull request #866: refactor: default to file scheme

[GitBox <gi...@apache.org>]

rollinq commented on pull request #866:
URL: https://github.com/apache/cordova-ios/pull/866#issuecomment-650172457


   I have a hard time understanding how to use custom scheme with cordova-ios 6, specifically the behaviour introduced here :
   
   In the description of the behaviour by erisu, it says : 
   
   > it will also validate against WKWebView handlesURLScheme, if it is not valid, it will default to app
   
   But in the code, the actual condition is :
   
   ```
   if(scheme == nil || [WKWebView handlesURLScheme:scheme]){
        scheme = @"app";
   }
   ```
   
   which, to my understanding of Objective-C, means that if it IS valid, it will default to app, cf. [WKWebView handlesURLScheme documentation here](https://developer.apple.com/documentation/webkit/wkwebview/2875370-handlesurlscheme?language=objc)
   
   Could someone clarify this to me ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org