[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1950: Refactor txn manager methods

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #1950: Refactor txn manager methods
URL: https://github.com/apache/incubator-doris/pull/1950#discussion_r333825032
 
 

 ##########
 File path: be/src/olap/txn_manager.cpp
 ##########
 @@ -76,6 +76,33 @@ TxnManager::TxnManager() {
     }
 }
 
+OLAPStatus TxnManager::prepare_txn(TPartitionId partition_id, const TabletSharedPtr& tablet, TTransactionId transaction_id, 
 
 Review comment:
   1. May two prepare_txn() merged into one mothod?
   2. partition_id can also get from tablet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org