You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/05/19 23:03:53 UTC
[kudu-CR] consensus peers: remove unnecessary pragma
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6934
to review the following change.
Change subject: consensus_peers: remove unnecessary pragma
......................................................................
consensus_peers: remove unnecessary pragma
These C++14 extensions are no longer being used, and gcc warns about the
unknown pragma (just can't win).
Change-Id: I993d882497d9e5c97a4946b8087ee9a8d0b21ebd
---
M src/kudu/consensus/consensus_peers.cc
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/6934/1
--
To view, visit http://gerrit.cloudera.org:8080/6934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I993d882497d9e5c97a4946b8087ee9a8d0b21ebd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] consensus peers: remove unnecessary pragma
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: consensus_peers: remove unnecessary pragma
......................................................................
consensus_peers: remove unnecessary pragma
These C++14 extensions are no longer being used, and gcc warns about the
unknown pragma (just can't win).
Change-Id: I993d882497d9e5c97a4946b8087ee9a8d0b21ebd
Reviewed-on: http://gerrit.cloudera.org:8080/6934
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/consensus/consensus_peers.cc
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I993d882497d9e5c97a4946b8087ee9a8d0b21ebd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] consensus peers: remove unnecessary pragma
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: consensus_peers: remove unnecessary pragma
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I993d882497d9e5c97a4946b8087ee9a8d0b21ebd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No