[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #1052: Fix RemoveOrphanFilesAction when file_path is not a qualified path

[GitBox <gi...@apache.org>]

jerryshao commented on a change in pull request #1052:
URL: https://github.com/apache/incubator-iceberg/pull/1052#discussion_r429005459



##########
File path: spark/src/main/java/org/apache/iceberg/actions/RemoveOrphanFilesAction.java
##########
@@ -141,7 +141,7 @@ public RemoveOrphanFilesAction deleteWith(Consumer<String> newDeleteFunc) {
     Dataset<Row> validFileDF = validDataFileDF.union(validMetadataFileDF);
     Dataset<Row> actualFileDF = buildActualFileDF();
 
-    Column joinCond = validFileDF.col("file_path").equalTo(actualFileDF.col("file_path"));
+    Column joinCond = actualFileDF.col("file_path").contains(validFileDF.col("file_path"));

Review comment:
       Ok, I see. If the file name is unique, then I think it would be fine to change to this way. Let me update the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org