You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by ahutsunshine <gi...@git.apache.org> on 2018/06/15 10:10:25 UTC

[GitHub] incubator-griffin pull request #309: change default database to h2

GitHub user ahutsunshine opened a pull request:

    https://github.com/apache/incubator-griffin/pull/309

    change default database to h2

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahutsunshine/incubator-griffin h2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #309
    
----
commit 28dd9935157934216dd5936dd6e9875cf5c1f7c2
Author: ahutsunshine <ah...@...>
Date:   2018-06-15T09:44:42Z

    change default database to h2

commit 2229535498915e1e34683d03600696514be13d99
Author: ahutsunshine <ah...@...>
Date:   2018-06-15T09:51:37Z

    change database name

----


---

[GitHub] incubator-griffin issue #309: change default database to h2

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/309
  
    hi YAO,
    
    We want to use h2 in dev profile(application-dev.properties), 
    but for prod profile, we need to application-prod.properties untouched.
    
    Could you change it to dev profile and resubmit your PR?
    
    
    Thanks a lot,
    William



---

[GitHub] incubator-griffin issue #309: change default database to h2

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/309
  
    seems good to me, I will merge it.
    
    Thanks,
    William


---

[GitHub] incubator-griffin pull request #309: change default database to h2

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/309


---

[GitHub] incubator-griffin issue #309: change default database to h2

Posted by ahutsunshine <gi...@git.apache.org>.

Github user ahutsunshine commented on the issue:

    https://github.com/apache/incubator-griffin/pull/309
  
    Hi @guoyuepeng ,
    Now I have changed database from postgresql to h2 in application-dev.properties. Pls check and merge.
    Thank you,
    Kevin Yao


---