You are viewing a plain text version of this content. The canonical link for it is here.
Posted to embperl@perl.apache.org by Axel Beckert <ab...@deuxchevaux.org> on 2014/10/16 01:54:10 UTC
Embperl test suite fails with at least CGI.pm 4.06 (likely CGI.pm >=
4.04)
Hi Gerald,
the following has been reported at https://bugs.debian.org/765125 and
-- according to our current understanding -- needs to be fixed for the
upcoming Debian Stable release as this breaks any Embperl installation
if a recent 4.xx CGI.pm version is installed, too.
CGI.pm 4.04 removed "some deprecated some long deprecated
modules/functions and includes refactoring to the temporary file
handling in CGI.pm."
This seems to have broken the meta data in $fdat{-upload}. After
installing CGI.pm 4.06, %fdat only contains this for
test/html/upload.htm:
'content' => 'Hi there!',
'multval' => 'A B C',
'single' => 'S',
'upload' => bless( \*{'File::Temp::$fh'}, 'CGI::File::Temp' )
Full output diff:
--- test/cmp/upload.htm 2014-10-13 23:44:08.657839025 +0200
+++ test/tmp/out.htm 2014-10-16 01:39:26.007068037 +0200
@@ -3,17 +3,21 @@
<head>
<title>Embperl Tests - File-Upload</title>
</head>
-
<h1>Embperl Tests - File-Upload</h1>
+$VAR1 = {
+ 'content' => 'Hi there!',
+ 'multval' => 'A B C',
+ 'single' => 'S',
+ 'upload' => bless( \*{'File::Temp::$fh'}, 'CGI::File::Temp' )
+ };
+
-Content-Disposition Content-Type
-^Filename: \d*upload-filename<br>
-Content-Type: test/plain<br>
-^CGI-Version
-^cgiok
-filehandle: Fh
-Info: Content-Disposition = form-data; name="upload"; filename="12upload-filename"
-Content-Type = test/plain
+Filename: 12upload-filename<br>
+Content-Type: <br>
+CGI-Version: 4.06
+cgiok 1
+filehandle: CGI::File::Temp
+Info:
no: 1
size: 2048
no: 2
@@ -27,7 +31,7 @@
buflen: 8219
Your file has the content
----------
-f1=abc1
+f1=abc1
[...]
@@ -47,4 +51,3 @@
</body>
</html>
-
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail)
X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)
---------------------------------------------------------------------
To unsubscribe, e-mail: embperl-unsubscribe@perl.apache.org
For additional commands, e-mail: embperl-help@perl.apache.org
AW: Embperl test suite fails with at least CGI.pm 4.06 (likely CGI.pm >= 4.04)
Posted by ri...@ecos.de.
Hi Axel,
sorry for the late reply and thanks for the patch. I have taken a quick look
and it seems ok to me. I will test it more in detail and create a new
Embperl release during the next weeks
Regards Gerald
> -----Ursprüngliche Nachricht-----
> Von: Axel Beckert [mailto:abe@deuxchevaux.org]
> Gesendet: Donnerstag, 23. Oktober 2014 02:49
> An: embperl@perl.apache.org
> Betreff: Re: Embperl test suite fails with at least CGI.pm 4.06 (likely
CGI.pm
> >= 4.04)
>
> Hi Gerald,
>
> On Thu, Oct 16, 2014 at 01:54:10AM +0200, Axel Beckert wrote:
> > the following has been reported at https://bugs.debian.org/765125 and
> > -- according to our current understanding -- needs to be fixed for the
> > upcoming Debian Stable release as this breaks any Embperl installation
> > if a recent 4.xx CGI.pm version is installed, too.
> >
> > CGI.pm 4.04 removed "some deprecated some long deprecated
> > modules/functions and includes refactoring to the temporary file
> > handling in CGI.pm."
> >
> > This seems to have broken the meta data in $fdat{-upload}. After
> > installing CGI.pm 4.06, %fdat only contains this for
> > test/html/upload.htm:
> >
> > 'content' => 'Hi there!',
> > 'multval' => 'A B C',
> > 'single' => 'S',
> > 'upload' => bless( \*{'File::Temp::$fh'}, 'CGI::File::Temp' )
>
> I've applied the following patch to the debian package so that Embperl can
> handle CGI.pm now (since version 4.04 IIRC) using CGI::File::Temp instead
of
> Fh. Additionally I had to make the testsuite more tolerant due to some
more
> possible results:
>
> https://anonscm.debian.org/cgit/pkg-perl/packages/libembperl-
> perl.git/tree
> /debian/patches/cgi-pm-4.04-compatibility.patch
>
> Please let me know if you find a better patch.
>
> Kind regards, Axel
> --
> /~\ Plain Text Ribbon Campaign | Axel Beckert
> \ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org
> (Mail)
> X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org
> (Mail+Jabber)
> / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/
> (Web)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: embperl-unsubscribe@perl.apache.org
> For additional commands, e-mail: embperl-help@perl.apache.org
>
>
> !DSPAM:416,544850b320532509216526!
---------------------------------------------------------------------
To unsubscribe, e-mail: embperl-unsubscribe@perl.apache.org
For additional commands, e-mail: embperl-help@perl.apache.org
Re: Embperl test suite fails with at least CGI.pm 4.06 (likely
CGI.pm >= 4.04)
Posted by Axel Beckert <ab...@deuxchevaux.org>.
Hi Gerald,
On Thu, Oct 16, 2014 at 01:54:10AM +0200, Axel Beckert wrote:
> the following has been reported at https://bugs.debian.org/765125 and
> -- according to our current understanding -- needs to be fixed for the
> upcoming Debian Stable release as this breaks any Embperl installation
> if a recent 4.xx CGI.pm version is installed, too.
>
> CGI.pm 4.04 removed "some deprecated some long deprecated
> modules/functions and includes refactoring to the temporary file
> handling in CGI.pm."
>
> This seems to have broken the meta data in $fdat{-upload}. After
> installing CGI.pm 4.06, %fdat only contains this for
> test/html/upload.htm:
>
> 'content' => 'Hi there!',
> 'multval' => 'A B C',
> 'single' => 'S',
> 'upload' => bless( \*{'File::Temp::$fh'}, 'CGI::File::Temp' )
I've applied the following patch to the debian package so that Embperl
can handle CGI.pm now (since version 4.04 IIRC) using CGI::File::Temp
instead of Fh. Additionally I had to make the testsuite more tolerant
due to some more possible results:
https://anonscm.debian.org/cgit/pkg-perl/packages/libembperl-perl.git/tree/debian/patches/cgi-pm-4.04-compatibility.patch
Please let me know if you find a better patch.
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail)
X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)
---------------------------------------------------------------------
To unsubscribe, e-mail: embperl-unsubscribe@perl.apache.org
For additional commands, e-mail: embperl-help@perl.apache.org