[jira] [Commented] (LIBCLOUD-1004) Allow EC2 driver to create_node from LaunchTemplate

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531955#comment-16531955 ] 

ASF GitHub Bot commented on LIBCLOUD-1004:
------------------------------------------

GitHub user rojopolis opened a pull request:

    https://github.com/apache/libcloud/pull/1224

    [LIBCLOUD-1004] Add launch template support to EC2 create_node

    ## Launch template support for EC2 create_node
    
    ### Allows Nodes to be created from EC2 Launch Templates
    
    This change allows Nodes to be created from predefined Launch Templates in EC2.  
    This is useful in a number of scenarios:
    * Organizational standards are implemented with Templates.
    * etc.
    
    The attributes specified in the call to create_node will take precedence over those defined in the template (per provider documentation).
    
    #### Provider docs: 
    - https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RunInstances.html
    - https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_LaunchTemplateSpecification.html
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rojopolis/libcloud LIBCLOUD-1004_ec2_instance_template

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1224
    
----
commit 42a3053ff4bf50ee58ea96504b6036bfeb2d9747
Author: Robert Jordan <rj...@...>
Date:   2018-07-03T21:01:37Z

    [LIBCLOUD-1004] Add launch template support to EC2 create_node

----


> Allow EC2 driver to create_node from LaunchTemplate
> ---------------------------------------------------
>
>                 Key: LIBCLOUD-1004
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-1004
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Robert Jordan
>            Priority: Trivial
>
> As a user of libcloud EC2 driver I would like to be able to create nodes based off of a predefined EC2 launch template.
> https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_LaunchTemplateSpecification.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)