[GitHub] [hive] zhangbutao commented on a diff in pull request #3260: HIVE-26192: JDBC data connector queries occur exception at cbo stage

[GitBox <gi...@apache.org>]

zhangbutao commented on code in PR #3260:
URL: https://github.com/apache/hive/pull/3260#discussion_r873641385


##########
ql/src/test/queries/clientpositive/dataconnector_mysql.q:
##########
@@ -14,6 +14,9 @@ SHOW DATABASES;
 USE db_mysql;
 SHOW TABLES;
 
+SHOW CREATE TABLE country;
+SELECT * FROM country;

Review Comment:
   > Can you add similar tests for the other supported connectors? (Oracle, MSSQL, etc.). I would like to ensure that we are not breaking something else while fixing this problem.
   
   Adding qtest for Oracle or MSSQL needs docker env like MySQL qtest. This test may be outside the scope of this pr but make sense. 
   But i think we should optimize this fix to only modify method of subclasses(MySQL, Oracle, MSSQL) instead of modifing parent class ` AbstractJDBCConnectorProvider.java` repeatedly. Because it is difficult to ensure that all jdbc connectors have consistent table structures.
    wdyt. thx. @zabetak 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org