You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/08/15 07:00:44 UTC

Review Request 61647: Added a TODO to correctly represent framework lifecycle in agent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61647/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-7890
    https://issues.apache.org/jira/browse/MESOS-7890


Repository: mesos


Description
-------

Currently, we store frameworks as "completed" in the agent when
the agent no longer has any active tasks for executors for the
framework. However, the framework may not be completed according
to the master. Ideally, the master informs the agent when a
framework is _actually_ completed and the agent represents these
"idle" frameworks as being in a non-completed state.


Diffs
-----

  src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 


Diff: https://reviews.apache.org/r/61647/diff/1/


Testing
-------

N/A


Thanks,

Benjamin Mahler


Re: Review Request 61647: Added a TODO to correctly represent framework lifecycle in agent.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61647/#review183550
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61647/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7890
>     https://issues.apache.org/jira/browse/MESOS-7890
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, we store frameworks as "completed" in the agent when
> the agent no longer has any active tasks for executors for the
> framework. However, the framework may not be completed according
> to the master. Ideally, the master informs the agent when a
> framework is _actually_ completed and the agent represents these
> "idle" frameworks as being in a non-completed state.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 
> 
> 
> Diff: https://reviews.apache.org/r/61647/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>