[GitHub] [iceberg] rdblue commented on pull request #3697: API: Add Immutables to FileScanTask's subclasses

[GitBox <gi...@apache.org>]

rdblue commented on pull request #3697:
URL: https://github.com/apache/iceberg/pull/3697#issuecomment-1033152659


   I don't see a real need to rewrite existing classes that don't change much. There just doesn't seem to be much value in these changes, but they do bring in risk because we have places where we know we need certain representations for Java Serializable to work properly.
   
   I would rather not pursue immutables, unless there is a significant benefit. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org